Differential D19672

Add Drydock logs to the RepositoryOperation UI
ClosedPublic
Actions

Authored by epriestley on Sep 14 2018, 1:50 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13197: 2018 Week 37 Bonus Content

Commits

rP92bcf859747d: Add Drydock logs to the RepositoryOperation UI

Summary

Depends on D19671. Ref T13197. See PHI873.

Expose logs in the RepositoryOperation UI. Nothing writes the logs yet, so these interfaces are currently always empty.

Test Plan

Screen Shot 2018-09-14 at 6.50.13 AM.png (785×1 px, 85 KB)

Screen Shot 2018-09-14 at 6.50.05 AM.png (273×915 px, 23 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 14 2018, 1:50 PM

Owners added a subscriber: Restricted Owners Package.Sep 14 2018, 1:50 PM

Harbormaster completed remote builds in B20822: Diff 47011.Sep 14 2018, 1:52 PM

epriestley requested review of this revision.Sep 14 2018, 1:52 PM

epriestley added a child revision: D19673: Write a trivial log when starting a repository operation.Sep 14 2018, 4:12 PM

amckinley accepted this revision.Sep 14 2018, 6:43 PM

This revision is now accepted and ready to land.Sep 14 2018, 6:43 PM

Closed by commit rP92bcf859747d: Add Drydock logs to the RepositoryOperation UI (authored by epriestley). · Explain WhySep 15 2018, 2:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

application/

PhabricatorDrydockApplication.php

2 lines

controller/

DrydockLogController.php

32 lines

DrydockLogListController.php

11 lines

DrydockRepositoryOperationViewController.php

15 lines

query/

DrydockLogSearchEngine.php

23 lines

Diff 47025

View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

View Options

src/applications/drydock/controller/DrydockLogController.php

View Options

src/applications/drydock/controller/DrydockLogListController.php

View Options

src/applications/drydock/controller/DrydockRepositoryOperationViewController.php

View Options

src/applications/drydock/query/DrydockLogSearchEngine.php

Add Drydock logs to the RepositoryOperation UIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47025

src/applications/drydock/application/PhabricatorDrydockApplication.php

src/applications/drydock/controller/DrydockLogController.php

src/applications/drydock/controller/DrydockLogListController.php

src/applications/drydock/controller/DrydockRepositoryOperationViewController.php

src/applications/drydock/query/DrydockLogSearchEngine.php

Add Drydock logs to the RepositoryOperation UI
ClosedPublic
Actions

Revision Contents
Changeset List