Page MenuHomePhabricator

Provide a convenient way to log arbitrary text in Drydock without needing structured log classes
ClosedPublic

Authored by epriestley on Sep 14 2018, 4:25 PM.

Details

Summary

Depends on D19673. Ref T13197. See PHI873.

Test Plan

Added some code like this:

$operation->logText('Nice convenient text logging.');

...then got:

Diff Detail

Repository
rP Phabricator
Branch
dlog4
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 20825
Build 28327: Run Core Tests
Build 28326: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Sep 14 2018, 4:25 PM
amckinley added inline comments.
src/applications/drydock/logtype/DrydockTextLogType.php
3–10

What's the maximum amount of text you can dump into a log? Worth documenting here?

This revision is now accepted and ready to land.Sep 14 2018, 6:55 PM

I think any "reasonable" amount should be fine. Maybe I'm not being imaginative enough, of course...

This revision was automatically updated to reflect the committed changes.