Page MenuHomePhabricator

Provide a convenient way to log arbitrary text in Drydock without needing structured log classes
ClosedPublic

Authored by epriestley on Sep 14 2018, 4:25 PM.
Tags
None
Referenced Files
F17627184: D19674.id47014.diff
Thu, Jul 10, 5:36 AM
Unknown Object (File)
Wed, Jul 2, 5:46 AM
Unknown Object (File)
Mon, Jun 16, 6:59 PM
Unknown Object (File)
May 31 2025, 3:56 PM
Unknown Object (File)
May 30 2025, 12:09 PM
Unknown Object (File)
May 30 2025, 10:47 AM
Unknown Object (File)
May 30 2025, 10:47 AM
Unknown Object (File)
Apr 27 2025, 4:32 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19673. Ref T13197. See PHI873.

Test Plan

Added some code like this:

$operation->logText('Nice convenient text logging.');

...then got:

Screen Shot 2018-09-14 at 9.23.09 AM.png (976×1 px, 137 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Sep 14 2018, 4:25 PM
amckinley added inline comments.
src/applications/drydock/logtype/DrydockTextLogType.php
4–11

What's the maximum amount of text you can dump into a log? Worth documenting here?

This revision is now accepted and ready to land.Sep 14 2018, 6:55 PM

I think any "reasonable" amount should be fine. Maybe I'm not being imaginative enough, of course...

This revision was automatically updated to reflect the committed changes.