Differential D19656

Remove legacy numeric Audit status constants
ClosedPublic
Actions

Authored by epriestley on Sep 11 2018, 2:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	May 6 2025, 10:13 AM

	Unknown Object (File)
	May 4 2025, 12:54 PM

	Unknown Object (File)
	Apr 24 2025, 7:53 AM

	Unknown Object (File)
	Apr 16 2025, 4:10 PM

	Unknown Object (File)
	Apr 15 2025, 8:20 AM

	Unknown Object (File)
	Apr 10 2025, 2:11 PM

	Unknown Object (File)
	Mar 30 2025, 8:23 AM

	Unknown Object (File)
	Mar 19 2025, 8:55 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13197: 2018 Week 37 Bonus Content

Commits

rPaaf22695515a: Remove legacy numeric Audit status constants

Summary

Depends on D19655. Ref T13197. These no longer have callers.

Test Plan

Grepped for these constants.

Diff Detail

Repository

rP Phabricator

Branch

audit11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20786
Build 28266: Run Core Tests
Build 28265: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 11 2018, 2:14 PM

Harbormaster completed remote builds in B20786: Diff 46976.Sep 11 2018, 2:15 PM

epriestley requested review of this revision.Sep 11 2018, 2:15 PM

epriestley added a child revision: D19657: Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_".Sep 11 2018, 2:22 PM

amckinley accepted this revision.Sep 11 2018, 8:21 PM

This revision is now accepted and ready to land.Sep 11 2018, 8:21 PM

Closed by commit rPaaf22695515a: Remove legacy numeric Audit status constants (authored by epriestley). · Explain WhySep 12 2018, 7:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

constants/

PhabricatorAuditCommitStatusConstants.php

19 lines

Diff 46976

View Options

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

Remove legacy numeric Audit status constantsClosedPublicActions