Page MenuHomePhabricator

Migrate remaining Audit database status constants
ClosedPublic

Authored by epriestley on Sep 11 2018, 2:05 PM.

Details

Summary

Depends on D19652. Ref T13197. See PHI851. This migrates the actual auditStatus on Commits, and older status transactions.

Test Plan
  • Ran migrations.
  • Spot-checked the database for sanity.
  • Ran some different queries, got unchanged results from before migration.
  • Reviewed historic audit state transactions, and accepted/raised concern on new audits. All state transactions appeared to generate properly.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a subscriber: Restricted Owners Package.Sep 11 2018, 2:05 PM
amckinley added inline comments.
resources/sql/autopatches/20180910.audit.04.xactions.php
22

No need to update old_value?

This revision is now accepted and ready to land.Sep 11 2018, 8:20 PM
epriestley added inline comments.
resources/sql/autopatches/20180910.audit.04.xactions.php
22

Oh! Nothing ever uses the old value so I thought it wasn't populated, but I went back and double checked and it actually is. So we don't need to, but I'll update this so we do just for completeness.

  • Also migrate old values.
  • Re-ran migration with bin/storage upgrade -f --apply ... --trace, saw reasonable-looking queries and ended up in a sensible database state.
This revision was automatically updated to reflect the committed changes.