Page MenuHomePhabricator

Make DiffusionCommitSearch accept modern (string) constants

Authored by epriestley on Sep 10 2018, 7:11 PM.



Depends on D19650. Ref T13197. Allow SearchCheckboxesField to have a "deprecated" map of older aliases, then convert them to modern values.

On the API method page, show all the values.

This technically resolves the issue in PHI841, although I still plan to migrate behind this.

Test Plan

Screen Shot 2018-09-10 at 12.10.21 PM.png (575×569 px, 68 KB)

  • Queried audits, fiddled with ?status=1,audited, etc.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley marked an inline comment as done.
epriestley added inline comments.

No more callers for this stuff.

amckinley added inline comments.

Should we add a little icon in this column to match the appearance of frozen conduit methods? (This is is kind of an actual consistency issue).

Or alternately, add 💚vs ❌on every row? (This is just bike-shedding).

This revision is now accepted and ready to land.Sep 10 2018, 9:09 PM
  • Add a little /!\ icon for deprecated, like Conduit methods get a level above.

Yeah, that's reasonable:

Screen Shot 2018-09-10 at 2.37.57 PM.png (529×579 px, 67 KB)

Although let me fiddle with this a little bit since it looks a touch awkward now.

  • Since the description is clear about "deprecated" anyway, just put the icon there instead of in a weird column?

This seems a little better, I think?

Screen Shot 2018-09-10 at 2.40.27 PM.png (550×528 px, 60 KB)

This seems a little better, I think?

Looks good to me.

This revision was automatically updated to reflect the committed changes.