Differential D19656

Remove legacy numeric Audit status constants
ClosedPublic
Actions

Authored by epriestley on Sep 11 2018, 2:14 PM.

Tags

None

Referenced Files

	F13038160: D19656.id46994.diff
	Mon, Apr 15, 11:05 PM

	Unknown Object (File)
	Mon, Apr 15, 11:32 AM

	Unknown Object (File)
	Thu, Apr 11, 9:30 PM

	Unknown Object (File)
	Thu, Apr 11, 2:42 PM

	Unknown Object (File)
	Sat, Apr 6, 3:17 AM

	Unknown Object (File)
	Sun, Mar 24, 8:24 PM

	Unknown Object (File)
	Wed, Mar 20, 11:26 AM

	Unknown Object (File)
	Feb 18 2024, 11:11 AM

View All 57 Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13197: 2018 Week 37 Bonus Content

Commits

rPaaf22695515a: Remove legacy numeric Audit status constants

Summary

Depends on D19655. Ref T13197. These no longer have callers.

Test Plan

Grepped for these constants.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 11 2018, 2:14 PM

Harbormaster completed remote builds in B20786: Diff 46976.Sep 11 2018, 2:15 PM

epriestley requested review of this revision.Sep 11 2018, 2:15 PM

epriestley added a child revision: D19657: Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_".Sep 11 2018, 2:22 PM

amckinley accepted this revision.Sep 11 2018, 8:21 PM

This revision is now accepted and ready to land.Sep 11 2018, 8:21 PM

Closed by commit rPaaf22695515a: Remove legacy numeric Audit status constants (authored by epriestley). · Explain WhySep 12 2018, 7:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

constants/

PhabricatorAuditCommitStatusConstants.php

19 lines

Diff 46994

View Options

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

Remove legacy numeric Audit status constantsClosedPublicActions