Paths

Table of Contentst

Differential D19595

Add more accessibility labels for screen readers
ClosedPublic
Actions

Authored by epriestley on Aug 17 2018, 5:56 PM.

Tags

None

Referenced Files

	F15423264: D19595.diff
	Sat, Mar 22, 2:22 PM

	F15413660: D19595.id46850.diff
	Wed, Mar 19, 8:23 PM

	F15407580: D19595.id.diff
	Tue, Mar 18, 6:27 PM

	F15392507: D19595.id46844.diff
	Sat, Mar 15, 3:37 PM

	Unknown Object (File)
	Mon, Mar 3, 2:16 AM

	Unknown Object (File)
	Wed, Feb 26, 12:41 AM

	Unknown Object (File)
	Feb 17 2025, 2:21 AM

	Unknown Object (File)
	Feb 9 2025, 6:20 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rP75a5dd8d8cc0: Add more accessibility labels for screen readers

Summary

Depends on D19594. See PHI823. Ref T13164.

Add a label for the "X" button in comment areas, like "Remove Action: Change Subscribers".
Add a label for the floating header display options menu in Differential.
Add role="button" to PHUIButtonView objects that we render with an <a ...> tag.

Test Plan

Viewed a revision with ?__aural__=true:

Saw "Remove Action: ..." label.
Saw "Display Options" label.
Used inspector to verify that some <a class="button" ...> now have <a class="button" role="button" ...>. This isn't exhaustive, but at least improves things. A specific example is the "edit", "reply", etc., actions on inline comments.

Diff Detail

Repository

Branch

acc2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20643
Build 28053: Run Core Tests
Build 28052: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 17 2018, 5:56 PM

Harbormaster completed remote builds in B20643: Diff 46844.Aug 17 2018, 5:58 PM

epriestley requested review of this revision.Aug 17 2018, 5:58 PM

amckinley accepted this revision.Aug 17 2018, 6:50 PM

This revision is now accepted and ready to land.Aug 17 2018, 6:50 PM

Closed by commit rP75a5dd8d8cc0: Add more accessibility labels for screen readers (authored by epriestley). · Explain WhyAug 17 2018, 8:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

differential/

view/

DifferentialChangesetListView.php

1 line

transactions/

view/

PhabricatorApplicationTransactionCommentView.php

6 lines

view/

phui/

PHUIButtonView.php

8 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

7 lines

transactions/

behavior-comment-actions.js

5 lines

phuix/

PHUIXButtonView.js

25 lines

Diff 46844

resources/celerity/map.php

Loading...

src/applications/differential/view/DifferentialChangesetListView.php

Loading...

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...

src/view/phui/PHUIButtonView.php

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...

webroot/rsrc/js/phuix/PHUIXButtonView.js

Loading...