Page MenuHomePhabricator

Add more accessibility labels for screen readers
ClosedPublic

Authored by epriestley on Aug 17 2018, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 4, 1:56 AM
Unknown Object (File)
Apr 21 2026, 4:10 PM
Unknown Object (File)
Apr 21 2026, 4:10 PM
Unknown Object (File)
Apr 19 2026, 5:55 AM
Unknown Object (File)
Apr 7 2026, 6:24 PM
Unknown Object (File)
Apr 7 2026, 5:55 AM
Unknown Object (File)
Feb 21 2026, 6:11 PM
Unknown Object (File)
Feb 5 2026, 2:01 AM
Subscribers
None

Details

Summary

Depends on D19594. See PHI823. Ref T13164.

  • Add a label for the "X" button in comment areas, like "Remove Action: Change Subscribers".
  • Add a label for the floating header display options menu in Differential.
  • Add role="button" to PHUIButtonView objects that we render with an <a ...> tag.
Test Plan

Viewed a revision with ?__aural__=true:

  • Saw "Remove Action: ..." label.
  • Saw "Display Options" label.
  • Used inspector to verify that some <a class="button" ...> now have <a class="button" role="button" ...>. This isn't exhaustive, but at least improves things. A specific example is the "edit", "reply", etc., actions on inline comments.

Diff Detail

Repository
rP Phabricator
Branch
acc2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20643
Build 28053: Run Core Tests
Build 28052: arc lint + arc unit