Page MenuHomePhabricator
Differential D19500

Fix changeset construction special case for empty commits in pre-commit hooks
ClosedPublic
Actions

Authored by epriestley on Jun 21 2018, 10:56 PM.
Tags
None
Referenced Files
F15413089: D19500.id46631.diff
Wed, Mar 19, 5:00 PM
F15380956: D19500.diff
Fri, Mar 14, 5:08 AM
F15379930: D19500.id46631.diff
Fri, Mar 14, 12:26 AM
F15333767: D19500.id46631.diff
Sat, Mar 8, 4:41 AM
Unknown Object (File)
Sun, Mar 2, 12:59 PM
Unknown Object (File)
Sun, Feb 23, 1:47 AM
Unknown Object (File)
Tue, Feb 18, 7:33 PM
Unknown Object (File)
Feb 18 2025, 5:14 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
avivey
Maniphest Tasks
T13151: Plans: 2018 Week 23 - Week 30 Bonus Content
T13155: Empty commit causes diffusion error output (but doesn't fail)
Commits
rP6136b8327575: Fix changeset construction special case for empty commits in pre-commit hooks
Summary

Fixes T13155. Ref T13151. A recent change (D19455) changed the return format here, but I missed this special case for empty commits.

Test Plan
  • T13155 has a good set of reproduction instructions.
  • Pushed an empty commit.
    • Before: bunch of warning log spew.
    • After: clean logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
2 lines

Diff 46631

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
Phabricator · Built by Phacility