Fix changeset construction special case for empty commits in pre-commit hooks
6136b8327575
Actions

Description

Fix changeset construction special case for empty commits in pre-commit hooks

Summary: Fixes T13155. Ref T13151. A recent change (D19455) changed the return format here, but I missed this special case for empty commits.

Test Plan:

T13155 has a good set of reproduction instructions.
Pushed an empty commit.
- Before: bunch of warning log spew.
- After: clean logs.

Reviewers: amckinley, avivey

Reviewed By: avivey

Maniphest Tasks: T13155, T13151

Differential Revision: https://secure.phabricator.com/D19500

Details

Provenance

epriestley	Authored on Jun 21 2018, 10:53 PM
epriestley	Pushed on Jun 21 2018, 11:43 PM

Reviewer

avivey

Differential Revision

D19500: Fix changeset construction special case for empty commits in pre-commit hooks

Parents

rP9db5ad3476a9: Allow null identities to be attached to commit objects

Branches

Unknown

Tags

Unknown

Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content
T13155: Empty commit causes diffusion error output (but doesn't fail)

Build Status

Buildable 20437
Build 27757: Run Core Tests

Event Timeline

epriestley committed rP6136b8327575: Fix changeset construction special case for empty commits in pre-commit hooks (authored by epriestley).Jun 21 2018, 11:43 PM

epriestley added a task: T13155: Empty commit causes diffusion error output (but doesn't fail).

epriestley added a task: T13151: Plans: 2018 Week 23 - Week 30 Bonus Content.

Harbormaster completed building B20437: rP6136b8327575: Fix changeset construction special case for empty commits in pre-commit hooks.Jun 21 2018, 11:44 PM

Changes (1)

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

rP6136b8327575

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php