Page MenuHomePhabricator
Differential D19500

Fix changeset construction special case for empty commits in pre-commit hooks
ClosedPublic
Actions

Authored by epriestley on Jun 21 2018, 10:56 PM.
Tags
None
Referenced Files
F15563818: D19500.id46630.diff
Wed, Apr 30, 10:09 AM
F15556321: D19500.id.diff
Mon, Apr 28, 3:47 PM
F15549578: D19500.diff
Sun, Apr 27, 6:40 AM
F15548765: D19500.diff
Sun, Apr 27, 1:56 AM
F15491332: D19500.id46630.diff
Sat, Apr 12, 2:07 AM
F15470381: D19500.id46631.diff
Apr 4 2025, 9:43 PM
F15458485: D19500.id46630.diff
Mar 31 2025, 4:01 AM
F15458484: D19500.id46631.diff
Mar 31 2025, 4:00 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
avivey
Maniphest Tasks
T13151: Plans: 2018 Week 23 - Week 30 Bonus Content
T13155: Empty commit causes diffusion error output (but doesn't fail)
Commits
rP6136b8327575: Fix changeset construction special case for empty commits in pre-commit hooks
Summary

Fixes T13155. Ref T13151. A recent change (D19455) changed the return format here, but I missed this special case for empty commits.

Test Plan
  • T13155 has a good set of reproduction instructions.
  • Pushed an empty commit.
    • Before: bunch of warning log spew.
    • After: clean logs.

Diff Detail

Repository
rP Phabricator
Branch
empty1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20436
Build 27756: Run Core Tests
Build 27755: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
2 lines

Diff 46630

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
Phabricator · Built by Phacility