Page MenuHomePhabricator

Allow Owners packages to be configured to ignore generated paths in Differential
ClosedPublic

Authored by epriestley on May 4 2018, 10:11 PM.
Tags
None
Referenced Files
F14406256: D19428.diff
Mon, Dec 23, 10:56 AM
Unknown Object (File)
Fri, Dec 13, 1:28 AM
Unknown Object (File)
Fri, Dec 6, 6:02 AM
Unknown Object (File)
Fri, Dec 6, 4:59 AM
Unknown Object (File)
Mon, Dec 2, 8:08 PM
Unknown Object (File)
Mon, Dec 2, 8:08 PM
Unknown Object (File)
Mon, Dec 2, 8:08 PM
Unknown Object (File)
Mon, Dec 2, 8:08 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19427. Ref T13130. See PHI251. Support configuring owners packages so they ignore generated paths.

This is still a little rough. A couple limitations:

  • It's hard to figure out how to use this control if you don't know what it's for, but we don't currently have a "CheckboxesEditField". I may add that soon.
  • The attribute ignore list doesn't apply to Diffusion, only Differential, which isn't obvious. I'll either try to make it work in Diffusion or note this somewhere.
  • No documentation yet (which could mitigate the other two issues a bit).

But the actual behavior seems to work fine.

Test Plan
  • Set a package to ignore paths with the "generated" attribute. Saw the package stop matching generated paths in Differential.
  • Removed the attribute from the ignore list.
  • Tried to set invalid attributes, got sensible errors.
  • Queried a package with Conduit, got the ignored attribute list.

Diff Detail

Repository
rP Phabricator
Branch
gen4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20281
Build 27533: Run Core Tests
Build 27532: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 4 2018, 10:11 PM
amckinley added inline comments.
src/applications/owners/storage/PhabricatorOwnersPackage.php
764–767

Name this $ignored just so we don't accidentally clobber this variable later?

This revision is now accepted and ready to land.May 5 2018, 2:18 AM
  • Agreed; use a more clear variable name.
  • Re-tested Conduit.
This revision was automatically updated to reflect the committed changes.