Page MenuHomePhabricator

Prepare to support an "Ignore generated files" flag in Owners
ClosedPublic

Authored by epriestley on May 4 2018, 8:30 PM.
Tags
None
Referenced Files
F18304890: D19426.diff
Sat, Aug 23, 11:06 PM
F18083067: D19426.diff
Tue, Aug 5, 8:46 AM
Unknown Object (File)
Jul 3 2025, 5:03 AM
Unknown Object (File)
Jun 17 2025, 7:07 PM
Unknown Object (File)
Jun 17 2025, 7:22 AM
Unknown Object (File)
Jun 16 2025, 8:59 PM
Unknown Object (File)
Jun 16 2025, 8:59 PM
Unknown Object (File)
Jun 16 2025, 8:53 PM
Subscribers
None

Details

Summary

Depends on D19425. Ref T13130. See PHI251. Now that changesets have a durable "generated" attribute, we can let owners packages check it when we're computing which packages are affected by a revision.

There's no way to actualy configure a package to have this behavior yet.

Test Plan
  • Created a revision affecting a generated file and a non-generated file.
    • When I faked mustMatchUngeneratedPaths() to return true;, saw the non-generated file get no packages owning it.
    • Normally: lots of packages owning it).
  • Created a revision affecting only generated files.
    • When I faked things, saw no Owners actions trigger.
    • Normally: some packages added reviewers or subscribers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable