Paths

Table of Contentst

Differential D19426

Prepare to support an "Ignore generated files" flag in Owners
ClosedPublic
Actions

Authored by epriestley on May 4 2018, 8:30 PM.

Tags

None

Referenced Files

	F15442787: D19426.id46467.diff
	Thu, Mar 27, 12:27 AM

	F15442451: D19426.id46473.diff
	Wed, Mar 26, 11:30 PM

	F15422107: D19426.id46467.diff
	Sat, Mar 22, 5:33 AM

	F15419639: D19426.id.diff
	Fri, Mar 21, 7:37 AM

	F15415614: D19426.diff
	Thu, Mar 20, 6:58 AM

	F15368945: D19426.diff
	Mar 12 2025, 4:35 AM

	Unknown Object (File)
	Feb 20 2025, 9:56 PM

	Unknown Object (File)
	Feb 20 2025, 9:56 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13130: Plans: 2018 Week 17/18 Bonus Content

Commits

rP5e2af4b9b5cd: Prepare to support an "Ignore generated files" flag in Owners

Summary

Depends on D19425. Ref T13130. See PHI251. Now that changesets have a durable "generated" attribute, we can let owners packages check it when we're computing which packages are affected by a revision.

There's no way to actualy configure a package to have this behavior yet.

Test Plan

Created a revision affecting a generated file and a non-generated file.
- When I faked mustMatchUngeneratedPaths() to return true;, saw the non-generated file get no packages owning it.
- Normally: lots of packages owning it).
Created a revision affecting only generated files.
- When I faked things, saw no Owners actions trigger.
- Normally: some packages added reviewers or subscribers.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 4 2018, 8:30 PM

Harbormaster completed remote builds in B20277: Diff 46467.May 4 2018, 8:31 PM

epriestley requested review of this revision.May 4 2018, 8:31 PM

epriestley added a child revision: D19427: Remove explicit "mailKey" from Owners packages.May 4 2018, 8:44 PM

amckinley accepted this revision.May 5 2018, 2:22 AM

This revision is now accepted and ready to land.May 5 2018, 2:22 AM

Closed by commit rP5e2af4b9b5cd: Prepare to support an "Ignore generated files" flag in Owners (authored by epriestley). · Explain WhyMay 5 2018, 3:46 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D21614: Lift peculiar side effect of path indexing out of indexer.Mar 15 2021, 5:50 PM

epriestley mentioned this in rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer.Mar 15 2021, 11:16 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialController.php

10 lines

editor/

DifferentialTransactionEditor.php

26 lines

herald/

HeraldDifferentialRevisionAdapter.php

5 lines

storage/

DifferentialDiff.php

18 lines

owners/

storage/

PhabricatorOwnersPackage.php

82 lines

Diff 46473

src/applications/differential/controller/DifferentialController.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/differential/herald/HeraldDifferentialRevisionAdapter.php

Loading...

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...