Page MenuHomePhabricator

Allow Owners packages to be configured to ignore generated paths in Differential
ClosedPublic

Authored by epriestley on May 4 2018, 10:11 PM.
Tags
None
Referenced Files
F19935401: D19428.id46469.diff
Sat, Apr 11, 10:17 PM
F19934832: D19428.id46471.diff
Sat, Apr 11, 6:28 PM
F19902070: D19428.id.diff
Mon, Mar 30, 3:04 PM
F19898371: D19428.diff
Sun, Mar 29, 12:12 PM
F19814683: D19428.diff
Mar 4 2026, 3:17 PM
F19713711: D19428.id46475.diff
Feb 11 2026, 11:37 PM
F19505853: D19428.id46471.diff
Jan 9 2026, 2:45 PM
F19505847: D19428.id46475.diff
Jan 9 2026, 2:43 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19427. Ref T13130. See PHI251. Support configuring owners packages so they ignore generated paths.

This is still a little rough. A couple limitations:

  • It's hard to figure out how to use this control if you don't know what it's for, but we don't currently have a "CheckboxesEditField". I may add that soon.
  • The attribute ignore list doesn't apply to Diffusion, only Differential, which isn't obvious. I'll either try to make it work in Diffusion or note this somewhere.
  • No documentation yet (which could mitigate the other two issues a bit).

But the actual behavior seems to work fine.

Test Plan
  • Set a package to ignore paths with the "generated" attribute. Saw the package stop matching generated paths in Differential.
  • Removed the attribute from the ignore list.
  • Tried to set invalid attributes, got sensible errors.
  • Queried a package with Conduit, got the ignored attribute list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 4 2018, 10:11 PM
amckinley added inline comments.
src/applications/owners/storage/PhabricatorOwnersPackage.php
764–767

Name this $ignored just so we don't accidentally clobber this variable later?

This revision is now accepted and ready to land.May 5 2018, 2:18 AM
  • Agreed; use a more clear variable name.
  • Re-tested Conduit.
This revision was automatically updated to reflect the committed changes.