Page MenuHomePhabricator

Remove explicit "mailKey" from Owners packages
ClosedPublic

Authored by epriestley on May 4 2018, 8:44 PM.
Tags
None
Referenced Files
F17945398: D19427.id.diff
Thu, Jul 31, 12:03 PM
F17926880: D19427.diff
Wed, Jul 30, 1:47 PM
F17782395: D19427.id46474.diff
Thu, Jul 24, 8:07 AM
F17763484: D19427.diff
Tue, Jul 22, 11:27 PM
F17701373: D19427.id46468.diff
Tue, Jul 15, 9:32 PM
Unknown Object (File)
Jun 29 2025, 7:15 PM
Unknown Object (File)
Jun 29 2025, 1:38 PM
Unknown Object (File)
Jun 29 2025, 6:24 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19426. Ref T13130. Ref T13065. While I'm making changes to Owners for "Ignore generated paths", clean up the "mailKey" column.

We recently (D19399) added code to automatically generate and manage mail keys so we don't need a ton of mailKey properties in the future. Migrate existing mail keys and blow away the explicit column on packages.

Test Plan

Ran migration, manually looked at the database and saw sensible data. Edited a package to send some mail, which looked good.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable