Page MenuHomePhabricator

In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft"
ClosedPublic

Authored by epriestley on Apr 21 2018, 8:09 PM.
Tags
None
Referenced Files
F14102916: D19398.id46402.diff
Tue, Nov 26, 8:32 PM
Unknown Object (File)
Sun, Nov 24, 8:20 PM
Unknown Object (File)
Sat, Nov 23, 4:18 AM
Unknown Object (File)
Thu, Nov 21, 4:10 AM
Unknown Object (File)
Fri, Nov 8, 7:58 PM
Unknown Object (File)
Fri, Nov 1, 7:44 PM
Unknown Object (File)
Oct 11 2024, 8:31 PM
Unknown Object (File)
Oct 9 2024, 9:27 AM
Subscribers
None

Details

Summary

Ref T13130. See PHI483. Currently, "Plan Changes + Draft" uses rules like "Plan Changes", not rules like "Draft", and allows "Accept".

This isn't consistent with how "Draft" and "Accept" work in other cases. Make "Plan Changes + Draft" more like "Draft" for consistency.

Also fix a string that didn't have a natural English version.

Test Plan
  • Added a failing build plan.
  • Created a revision.
  • Loaded the revision before builds completed, saw a nicer piece of text about "waiting for builds" instead of "waiting for 2 build(s)".
  • Builds failed, which automatically demoted the reivsion to "Changes Planned + Draft".
  • As the author and as a reviewer, verified all the actions available to me made sense (particularly, no "Accept").
  • Abandoned the revision to test "Abandoned + Draft".
  • As the author and as a reviewer, verified all the actions available to me made sense.
  • Reclaimed the revision, then used "Request Review" to send it to "Needs Review". Verified that actions made sense and, e.g., reviewers could now "Accept" normally.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20213
Build 27429: Run Core Tests
Build 27428: arc lint + arc unit