Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15439974
D19398.id46402.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D19398.id46402.diff
View Options
diff --git a/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php b/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
@@ -162,7 +162,7 @@
'closed. Only open revisions can be accepted.'));
}
- if ($object->isDraft()) {
+ if ($object->isDraft() || !$object->getShouldBroadcast()) {
throw new Exception(
pht('You can not accept a draft revision.'));
}
diff --git a/src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php b/src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php
@@ -73,7 +73,7 @@
'not own.'));
}
- if ($object->isDraft()) {
+ if ($object->isDraft() || !$object->getShouldBroadcast()) {
throw new Exception(
pht('You can not request changes to a draft revision.'));
}
diff --git a/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php b/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
--- a/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
+++ b/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
@@ -1659,6 +1659,14 @@
'you can no longer see were discarded.',
),
+ 'This draft revision will be sent for review once %s '.
+ 'build(s) pass: %s.' => array(
+ 'This draft revision will be sent for review once this build '.
+ 'passes: %2$s.',
+ 'This draft revision will be sent for review once these builds '.
+ 'pass: %2$s.',
+ ),
+
);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 27, 10:37 AM (6 d, 11 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7587074
Default Alt Text
D19398.id46402.diff (1 KB)
Attached To
Mode
D19398: In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft"
Attached
Detach File
Event Timeline
Log In to Comment