In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft"
16af0d35e510
Actions

Description

In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft"

Summary:
Ref T13130. See PHI483. Currently, "Plan Changes + Draft" uses rules like "Plan Changes", not rules like "Draft", and allows "Accept".

This isn't consistent with how "Draft" and "Accept" work in other cases. Make "Plan Changes + Draft" more like "Draft" for consistency.

Also fix a string that didn't have a natural English version.

Test Plan:

Added a failing build plan.
Created a revision.
Loaded the revision before builds completed, saw a nicer piece of text about "waiting for builds" instead of "waiting for 2 build(s)".
Builds failed, which automatically demoted the reivsion to "Changes Planned + Draft".
As the author and as a reviewer, verified all the actions available to me made sense (particularly, no "Accept").
Abandoned the revision to test "Abandoned + Draft".
As the author and as a reviewer, verified all the actions available to me made sense.
Reclaimed the revision, then used "Request Review" to send it to "Needs Review". Verified that actions made sense and, e.g., reviewers could now "Accept" normally.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13130