Page MenuHomePhabricator

In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft"
ClosedPublic

Authored by epriestley on Apr 21 2018, 8:09 PM.
Tags
None
Referenced Files
F13358329: D19398.diff
Tue, Jun 25, 7:17 AM
F13357030: D19398.id46405.diff
Mon, Jun 24, 10:35 PM
F13357028: D19398.id46402.diff
Mon, Jun 24, 10:35 PM
F13357027: D19398.id.diff
Mon, Jun 24, 10:35 PM
F13348776: D19398.id46405.diff
Sat, Jun 22, 11:43 PM
F13343679: D19398.diff
Fri, Jun 21, 5:01 AM
F13265879: D19398.diff
May 28 2024, 6:53 AM
F13257928: D19398.diff
May 26 2024, 5:32 AM
Subscribers
None

Details

Summary

Ref T13130. See PHI483. Currently, "Plan Changes + Draft" uses rules like "Plan Changes", not rules like "Draft", and allows "Accept".

This isn't consistent with how "Draft" and "Accept" work in other cases. Make "Plan Changes + Draft" more like "Draft" for consistency.

Also fix a string that didn't have a natural English version.

Test Plan
  • Added a failing build plan.
  • Created a revision.
  • Loaded the revision before builds completed, saw a nicer piece of text about "waiting for builds" instead of "waiting for 2 build(s)".
  • Builds failed, which automatically demoted the reivsion to "Changes Planned + Draft".
  • As the author and as a reviewer, verified all the actions available to me made sense (particularly, no "Accept").
  • Abandoned the revision to test "Abandoned + Draft".
  • As the author and as a reviewer, verified all the actions available to me made sense.
  • Reclaimed the revision, then used "Request Review" to send it to "Needs Review". Verified that actions made sense and, e.g., reviewers could now "Accept" normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable