Page MenuHomePhabricator

When following a link to a particular line ("/example.txt$12"), scroll to that line
ClosedPublic

Authored by epriestley on Apr 11 2018, 9:47 PM.
Tags
None
Referenced Files
F13243287: D19350.diff
Thu, May 23, 3:41 AM
F13236457: D19350.diff
Tue, May 21, 9:47 AM
F13233165: D19350.diff
Tue, May 21, 1:45 AM
F13221637: D19350.diff
Sun, May 19, 2:56 AM
F13204090: D19350.diff
Wed, May 15, 12:20 AM
F13191974: D19350.id46295.diff
Sun, May 12, 3:34 AM
F13186870: D19350.diff
Sat, May 11, 4:11 AM
Unknown Object (File)
Tue, May 7, 7:15 AM
Subscribers
None

Details

Summary

Depends on D19349. Ref T13105. This was the behavior in Diffusion before with a little hard-coded snippet.

Remove that snippet ("diffusion-jump-to") and add a more general-purpose snippet to SourceView.

This is a tiny bit hacky still (and probably doesn't work quite right with Quicksand) but gets things working again and works in all of Files, Paste, and Diffusion.

Test Plan

Followed links to particular lines in Paste, Files and Diffusion; got scrolled to the right place.

Diff Detail

Repository
rP Phabricator
Branch
docu5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20107
Build 27278: Run Core Tests
Build 27277: arc lint + arc unit