Page MenuHomePhabricator

When you make the file tree huge, scroll to the right, and then toggle it, stop it from growing
ClosedPublic

Authored by epriestley on Apr 11 2018, 8:57 PM.
Tags
None
Referenced Files
F15503979: D19347.diff
Mon, Apr 14, 2:50 PM
F15502507: D19347.diff
Mon, Apr 14, 1:39 AM
F15450572: D19347.id46285.diff
Fri, Mar 28, 4:30 PM
F15443381: D19347.id46285.diff
Thu, Mar 27, 4:08 AM
F15423588: D19347.id46285.diff
Sat, Mar 22, 4:12 PM
F15403089: D19347.id46285.diff
Mar 18 2025, 1:51 AM
F15367603: D19347.id46285.diff
Mar 11 2025, 8:03 PM
F15304149: D19347.id46285.diff
Mar 6 2025, 1:26 AM
Subscribers
None

Details

Summary

Depends on D19346. Ref PHI568. I love Javascript.

Test Plan
  • Viewed a revision.
  • Dragged file tree view really wide.
  • Scrolled document to the right.
  • Toggled file tree off and on by pressing "f" twice.
    • Before patch: file tree grew wider and wider after it was toggled.
    • After patch: file tree stayed the same size after it was toggled.
  • Dragged to various widths and reloaded to make sure the "sticky across reloads" behavior still works.
  • Scrolled right, dragged the tree a bit, then reloaded and didn't see it flip out.

Diff Detail

Repository
rP Phabricator
Branch
docu2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20104
Build 27272: Run Core Tests
Build 27271: arc lint + arc unit