Differential D19344

Give the "Filetree" UI element an explicit background color
ClosedPublic
Actions

Authored by epriestley on Apr 11 2018, 4:42 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13120: Plans: 2018 Week 15 Bonus Content

Commits

rPd6ef32a7b754: Give the "Filetree" UI element an explicit background color

Summary

See PHI568. If you make the file tree UI very wide so that the page generates a horizontal scrollbar and then scroll the page, the page content can paint underneath the menu.

The menu already has a z-index to make it render above the content, but doesn't actually have a background. Give it a background.

The "transparent" rule was added in D16346 but I don't see any reason why we actually need it there, so I think this probably won't break anything.

Test Plan

Screen Shot 2018-04-11 at 9.42.15 AM.png (1×1 px, 192 KB)

Diff Detail

Repository

rP Phabricator

Branch

trans1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20080
Build 27245: Run Core Tests
Build 27244: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	405 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("") Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	2 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	1 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	1 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 6 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 3 assertions passed.
		View Full Test Results (1 Failed · 348 Passed)