Page MenuHomePhabricator

Give the "Filetree" UI element an explicit background color
ClosedPublic

Authored by epriestley on Apr 11 2018, 4:42 PM.
Tags
None
Referenced Files
F15557223: D19344.id.diff
Mon, Apr 28, 8:33 PM
F15550471: D19344.diff
Sun, Apr 27, 11:52 AM
F15537983: D19344.id46257.diff
Thu, Apr 24, 5:02 PM
F15519923: D19344.id46282.diff
Sun, Apr 20, 1:10 AM
F15491258: D19344.id46258.diff
Sat, Apr 12, 1:01 AM
F15442430: D19344.id.diff
Mar 26 2025, 11:24 PM
F15436214: D19344.diff
Mar 25 2025, 12:40 PM
F15285115: D19344.diff
Mar 4 2025, 11:38 AM
Subscribers
None

Details

Summary

See PHI568. If you make the file tree UI very wide so that the page generates a horizontal scrollbar and then scroll the page, the page content can paint underneath the menu.

The menu already has a z-index to make it render above the content, but doesn't actually have a background. Give it a background.

The "transparent" rule was added in D16346 but I don't see any reason why we actually need it there, so I think this probably won't break anything.

Test Plan

Screen Shot 2018-04-11 at 9.42.15 AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable