Page MenuHomePhabricator

Redesign Application Search
ClosedPublic

Authored by chad on Jul 30 2016, 2:55 AM.
Tags
None
Referenced Files
F14019878: D16346.diff
Tue, Nov 5, 11:44 PM
F14018018: D16346.id39347.diff
Tue, Nov 5, 3:10 AM
F14017809: D16346.id39309.diff
Mon, Nov 4, 11:13 PM
F14017595: D16346.id.diff
Mon, Nov 4, 7:21 PM
F14016940: D16346.id39347.diff
Mon, Nov 4, 11:42 AM
F14016939: D16346.id39344.diff
Mon, Nov 4, 11:41 AM
F14016931: D16346.id39311.diff
Mon, Nov 4, 11:31 AM
F14015535: D16346.diff
Sun, Nov 3, 8:40 PM
Subscribers

Details

Summary

This moves aphront-side-nav to use same table css display as profile nav. Slightly less code to support. Cleans up AppSearch UI, think I've gotten all the edge cases here, but bang on it, can hold until after release cut.

Test Plan

Config, Maniphest, Differential, Diffusion, Home.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Redesign Application Search.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
  • tweaky font size once more

feels reasonably tight to me now. spent some time on mobile too.

epriestley edited edge metadata.

I found one actual bug with file trees, but couldn't really break this:


Subjective gut design stuff:

  • Right edge of the menu feels a little soft visually to me because there's no border or shadow. I'll probably get used to this and I think it's probably just things being different, but it jumped out at me at first glance. Some particular contrast for me with the crumbs, which do have a border.

Screen Shot 2016-07-31 at 6.26.29 AM.png (252×194 px, 11 KB)

  • There's sort of a lot of space at the bottom of the list above the pager. Looks a little odd to me, especially in Maniphest where we have snug controls, a big gap,then paging controls:

Screen Shot 2016-07-31 at 6.20.58 AM.png (294×369 px, 17 KB)

  • Pulling "Saved Queries" out of a box feels slightly odd to me since it's more of a form/control kind of thing? This is pre-existing to some degree since it's a form/control with no "Submit" button. Just mentioning it for completeness.

Screen Shot 2016-07-31 at 6.28.12 AM.png (1×1 px, 125 KB)


Technical stuff:

  • Overly long custom query names overflow oddly:

Screen Shot 2016-07-31 at 6.18.33 AM.png (114×280 px, 11 KB)

  • Hiding the file nav in Differential by pressing "F" does not work -- it hides some of the chrome/controls, but not the nav itself:

Screen Shot 2016-07-31 at 6.20.08 AM.png (350×283 px, 31 KB)

  • Did we always center-align "polaroid" results in Pholio/Macro? Probably? Slighly weird? This is very likely not new?

Screen Shot 2016-07-31 at 6.23.44 AM.png (665×1 px, 231 KB)

  • Calendar ends up looking pretty odd, but we can fix that separately. Possibly we should remove setCollapsed() from PhabricatorApplicationSearchResultView since I think Calendar is the only callsite and it's probably always weird-looking after this change?
This revision is now accepted and ready to land.Jul 31 2016, 1:34 PM

Whoops, missed testing file browser in Differential. Yeah Pholio/Macro have been centered now ... for like a year?

chad edited edge metadata.
  • fix differential file browser
  • fix calendar month / day
This revision is now accepted and ready to land.Aug 1 2016, 5:53 PM
This revision was automatically updated to reflect the committed changes.

ok, landed. roll secure so I can see how bad production is?

Overall seems a step forward. It's a little on the sparse side, but I didn't want to embellish anything on it yet, like the footer, without living in it for a little bit.

still needs polish: filter panel interaction, saving search queries, maybe cap the end of the object box list so it's not dangling.