This moves aphront-side-nav to use same table css display as profile nav. Slightly less code to support. Cleans up AppSearch UI, think I've gotten all the edge cases here, but bang on it, can hold until after release cut.
Details
Details
- Reviewers
epriestley - Commits
- rP11e84c166a38: Redesign Application Search
Config, Maniphest, Differential, Diffusion, Home.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I found one actual bug with file trees, but couldn't really break this:
Subjective gut design stuff:
- Right edge of the menu feels a little soft visually to me because there's no border or shadow. I'll probably get used to this and I think it's probably just things being different, but it jumped out at me at first glance. Some particular contrast for me with the crumbs, which do have a border.
- There's sort of a lot of space at the bottom of the list above the pager. Looks a little odd to me, especially in Maniphest where we have snug controls, a big gap,then paging controls:
- Pulling "Saved Queries" out of a box feels slightly odd to me since it's more of a form/control kind of thing? This is pre-existing to some degree since it's a form/control with no "Submit" button. Just mentioning it for completeness.
Technical stuff:
- Overly long custom query names overflow oddly:
- Hiding the file nav in Differential by pressing "F" does not work -- it hides some of the chrome/controls, but not the nav itself:
- Did we always center-align "polaroid" results in Pholio/Macro? Probably? Slighly weird? This is very likely not new?
- Calendar ends up looking pretty odd, but we can fix that separately. Possibly we should remove setCollapsed() from PhabricatorApplicationSearchResultView since I think Calendar is the only callsite and it's probably always weird-looking after this change?
Comment Actions
Whoops, missed testing file browser in Differential. Yeah Pholio/Macro have been centered now ... for like a year?
Comment Actions
Overall seems a step forward. It's a little on the sparse side, but I didn't want to embellish anything on it yet, like the footer, without living in it for a little bit.
Comment Actions
still needs polish: filter panel interaction, saving search queries, maybe cap the end of the object box list so it's not dangling.