Page MenuHomePhabricator

Give the "Filetree" UI element an explicit background color
ClosedPublic

Authored by epriestley on Apr 11 2018, 4:42 PM.
Tags
None
Referenced Files
F13153429: D19344.diff
Sun, May 5, 3:10 AM
Unknown Object (File)
Fri, May 3, 3:01 PM
Unknown Object (File)
Mar 30 2024, 4:23 PM
Unknown Object (File)
Mar 30 2024, 4:23 PM
Unknown Object (File)
Mar 30 2024, 4:23 PM
Unknown Object (File)
Mar 30 2024, 4:23 PM
Unknown Object (File)
Mar 22 2024, 7:46 PM
Unknown Object (File)
Mar 5 2024, 4:06 PM
Subscribers
None

Details

Summary

See PHI568. If you make the file tree UI very wide so that the page generates a horizontal scrollbar and then scroll the page, the page content can paint underneath the menu.

The menu already has a z-index to make it render above the content, but doesn't actually have a background. Give it a background.

The "transparent" rule was added in D16346 but I don't see any reason why we actually need it there, so I think this probably won't break anything.

Test Plan

Screen Shot 2018-04-11 at 9.42.15 AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Branch
trans1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20081
Build 27247: Run Core Tests
Build 27246: arc lint + arc unit