Page MenuHomePhabricator

When administrators revoke SSH keys, don't include a "security warning" in the mail
ClosedPublic

Authored by epriestley on Jan 22 2018, 1:59 AM.
Tags
None
Referenced Files
F14758631: D18907.id45368.diff
Wed, Jan 22, 8:33 AM
F14756815: D18907.id45323.diff
Tue, Jan 21, 8:34 PM
Unknown Object (File)
Tue, Jan 21, 12:44 PM
Unknown Object (File)
Tue, Jan 21, 11:07 AM
Unknown Object (File)
Sat, Dec 28, 12:25 PM
Unknown Object (File)
Tue, Dec 24, 3:47 AM
Unknown Object (File)
Dec 16 2024, 5:44 PM
Unknown Object (File)
Dec 6 2024, 12:53 AM
Subscribers
None

Details

Summary

Depends on D18906. Ref T13043. When SSH keys are edited, we normally include a warning that if you don't recognize the activity you might have problems in the mail body.

Currently, this warning is also shown for revocations with bin/auth revoke --type ssh. However, these revocations are safe (revocations are generally not dangerous anyway) and almost certainly legitimate and administrative, so don't warn users about them.

Test Plan
  • Created and revoked a key.
  • Creation mail still had warning; revocation mail no longer did.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable