Page MenuHomePhabricator

When administrators revoke SSH keys, don't include a "security warning" in the mail
ClosedPublic

Authored by epriestley on Jan 22 2018, 1:59 AM.
Tags
None
Referenced Files
F12829358: D18907.id45368.diff
Thu, Mar 28, 11:28 AM
Unknown Object (File)
Fri, Mar 15, 6:55 AM
Unknown Object (File)
Wed, Feb 28, 1:25 PM
Unknown Object (File)
Wed, Feb 28, 11:47 AM
Unknown Object (File)
Dec 20 2023, 9:52 AM
Unknown Object (File)
Dec 13 2023, 11:13 PM
Unknown Object (File)
Nov 30 2023, 4:21 AM
Unknown Object (File)
Nov 17 2023, 6:02 AM
Subscribers
None

Details

Summary

Depends on D18906. Ref T13043. When SSH keys are edited, we normally include a warning that if you don't recognize the activity you might have problems in the mail body.

Currently, this warning is also shown for revocations with bin/auth revoke --type ssh. However, these revocations are safe (revocations are generally not dangerous anyway) and almost certainly legitimate and administrative, so don't warn users about them.

Test Plan
  • Created and revoked a key.
  • Creation mail still had warning; revocation mail no longer did.

Diff Detail

Repository
rP Phabricator
Branch
revoke17
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19110
Build 25800: Run Core Tests
Build 25799: arc lint + arc unit