Tags

None

Referenced Files

	F15588043: D18904.id45364.diff
	Fri, May 9, 3:46 AM

	F15559388: D18904.id.diff
	Tue, Apr 29, 8:31 AM

	F15556868: D18904.diff
	Mon, Apr 28, 6:47 PM

	F15512580: D18904.id45364.diff
	Thu, Apr 17, 11:42 AM

	F15512579: D18904.id45320.diff
	Thu, Apr 17, 11:42 AM

	F15511322: D18904.diff
	Thu, Apr 17, 1:24 AM

	F15454272: D18904.id45320.diff
	Mar 29 2025, 5:40 PM

	F15454158: D18904.id45364.diff
	Mar 29 2025, 4:40 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13043: Improve authentication revocation behaviors

Commits

rPcab2bba6f2f7: Remove "passwordHash" and "passwordSalt" from User objects

Summary

Ref T13043. After D18903, this data has migrated to shared infrastructure and has no remaining readers or writers.

Just delete it now, since the cost of a mistake here is very small (users need to "Forgot Password?" and pick a new password).

Test Plan

Grepped for passwordHash, passwordSalt, and variations.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 22 2018, 1:20 AM

Harbormaster completed remote builds in B19107: Diff 45320.Jan 22 2018, 1:21 AM

epriestley requested review of this revision.Jan 22 2018, 1:21 AM

epriestley added a child revision: D18906: Add a rate limit for guessing old passwords when changing passwords.Jan 22 2018, 1:52 AM

amckinley accepted this revision.Jan 23 2018, 7:48 PM

This revision is now accepted and ready to land.Jan 23 2018, 7:48 PM

Closed by commit rPcab2bba6f2f7: Remove "passwordHash" and "passwordSalt" from User objects (authored by epriestley). · Explain WhyJan 23 2018, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Remove "passwordHash" and "passwordSalt" from User objects
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 45364

resources/sql/autopatches/20180121.auth.05.accountnuke.sql

src/applications/people/storage/PhabricatorUser.php

Remove "passwordHash" and "passwordSalt" from User objectsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45364

resources/sql/autopatches/20180121.auth.05.accountnuke.sql

src/applications/people/storage/PhabricatorUser.php

Remove "passwordHash" and "passwordSalt" from User objects
ClosedPublic
Actions

Revision Contents
Changeset List