Page MenuHomePhabricator

When administrators revoke SSH keys, don't include a "security warning" in the mail
ClosedPublic

Authored by epriestley on Jan 22 2018, 1:59 AM.
Tags
None
Referenced Files
F15588495: D18907.diff
Fri, May 9, 7:59 AM
F15570022: D18907.id45368.diff
Sun, May 4, 7:23 AM
F15565815: D18907.id45323.diff
Thu, May 1, 9:19 AM
F15565185: D18907.id45368.diff
Wed, Apr 30, 11:57 PM
F15560957: D18907.id.diff
Tue, Apr 29, 5:27 PM
F15557741: D18907.diff
Mon, Apr 28, 11:01 PM
F15491316: D18907.diff
Sat, Apr 12, 1:51 AM
F15474248: D18907.id45323.diff
Apr 6 2025, 6:49 AM
Subscribers
None

Details

Summary

Depends on D18906. Ref T13043. When SSH keys are edited, we normally include a warning that if you don't recognize the activity you might have problems in the mail body.

Currently, this warning is also shown for revocations with bin/auth revoke --type ssh. However, these revocations are safe (revocations are generally not dangerous anyway) and almost certainly legitimate and administrative, so don't warn users about them.

Test Plan
  • Created and revoked a key.
  • Creation mail still had warning; revocation mail no longer did.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable