Page MenuHomePhabricator

When administrators revoke SSH keys, don't include a "security warning" in the mail
ClosedPublic

Authored by epriestley on Jan 22 2018, 1:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 2:53 PM
Unknown Object (File)
Mon, Nov 11, 8:47 AM
Unknown Object (File)
Sun, Nov 3, 7:08 PM
Unknown Object (File)
Mon, Oct 28, 3:04 AM
Unknown Object (File)
Oct 19 2024, 3:03 AM
Unknown Object (File)
Oct 14 2024, 11:00 AM
Unknown Object (File)
Oct 10 2024, 3:45 PM
Unknown Object (File)
Oct 10 2024, 12:24 PM
Subscribers
None

Details

Summary

Depends on D18906. Ref T13043. When SSH keys are edited, we normally include a warning that if you don't recognize the activity you might have problems in the mail body.

Currently, this warning is also shown for revocations with bin/auth revoke --type ssh. However, these revocations are safe (revocations are generally not dangerous anyway) and almost certainly legitimate and administrative, so don't warn users about them.

Test Plan
  • Created and revoked a key.
  • Creation mail still had warning; revocation mail no longer did.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable