Page MenuHomePhabricator

When administrators revoke SSH keys, don't include a "security warning" in the mail
ClosedPublic

Authored by epriestley on Jan 22 2018, 1:59 AM.
Tags
None
Referenced Files
F18737708: D18907.id45368.diff
Wed, Oct 1, 12:11 PM
F18678290: D18907.id45323.diff
Thu, Sep 25, 10:33 PM
F18617737: D18907.diff
Sep 14 2025, 10:01 PM
F18586229: D18907.id.diff
Sep 11 2025, 5:52 PM
F18585249: D18907.diff
Sep 11 2025, 2:47 PM
F18578640: D18907.diff
Sep 10 2025, 10:53 PM
F18551481: D18907.diff
Sep 8 2025, 12:26 PM
F18509244: D18907.id.diff
Sep 5 2025, 3:18 AM
Subscribers
None

Details

Summary

Depends on D18906. Ref T13043. When SSH keys are edited, we normally include a warning that if you don't recognize the activity you might have problems in the mail body.

Currently, this warning is also shown for revocations with bin/auth revoke --type ssh. However, these revocations are safe (revocations are generally not dangerous anyway) and almost certainly legitimate and administrative, so don't warn users about them.

Test Plan
  • Created and revoked a key.
  • Creation mail still had warning; revocation mail no longer did.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable