Page MenuHomePhabricator

When administrators revoke SSH keys, don't include a "security warning" in the mail
ClosedPublic

Authored by epriestley on Jan 22 2018, 1:59 AM.
Tags
None
Referenced Files
F17816284: D18907.id45368.diff
Fri, Jul 25, 10:39 PM
F17762871: D18907.diff
Tue, Jul 22, 10:40 PM
Unknown Object (File)
May 10 2025, 6:26 AM
Unknown Object (File)
May 9 2025, 7:59 AM
Unknown Object (File)
May 4 2025, 7:23 AM
Unknown Object (File)
May 1 2025, 9:19 AM
Unknown Object (File)
Apr 30 2025, 11:57 PM
Unknown Object (File)
Apr 29 2025, 5:27 PM
Subscribers
None

Details

Summary

Depends on D18906. Ref T13043. When SSH keys are edited, we normally include a warning that if you don't recognize the activity you might have problems in the mail body.

Currently, this warning is also shown for revocations with bin/auth revoke --type ssh. However, these revocations are safe (revocations are generally not dangerous anyway) and almost certainly legitimate and administrative, so don't warn users about them.

Test Plan
  • Created and revoked a key.
  • Creation mail still had warning; revocation mail no longer did.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable