Page MenuHomePhabricator

When administrators revoke SSH keys, don't include a "security warning" in the mail
ClosedPublic

Authored by epriestley on Jan 22 2018, 1:59 AM.
Tags
None
Referenced Files
F13044162: D18907.diff
Wed, Apr 17, 3:09 PM
Unknown Object (File)
Thu, Apr 11, 8:30 AM
Unknown Object (File)
Thu, Apr 11, 7:18 AM
Unknown Object (File)
Tue, Apr 2, 3:21 PM
Unknown Object (File)
Tue, Apr 2, 6:55 AM
Unknown Object (File)
Thu, Mar 28, 11:28 AM
Unknown Object (File)
Mar 15 2024, 6:55 AM
Unknown Object (File)
Feb 28 2024, 1:25 PM
Subscribers
None

Details

Summary

Depends on D18906. Ref T13043. When SSH keys are edited, we normally include a warning that if you don't recognize the activity you might have problems in the mail body.

Currently, this warning is also shown for revocations with bin/auth revoke --type ssh. However, these revocations are safe (revocations are generally not dangerous anyway) and almost certainly legitimate and administrative, so don't warn users about them.

Test Plan
  • Created and revoked a key.
  • Creation mail still had warning; revocation mail no longer did.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable