Page MenuHomePhabricator

Fix Mercurial commit history ordering
ClosedPublic

Authored by epriestley on Dec 5 2017, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 10:10 AM
Unknown Object (File)
Thu, May 2, 2:22 PM
Unknown Object (File)
Thu, Apr 25, 3:42 AM
Unknown Object (File)
Wed, Apr 24, 10:26 PM
Unknown Object (File)
Sat, Apr 20, 2:52 AM
Unknown Object (File)
Tue, Apr 16, 5:48 PM
Unknown Object (File)
Thu, Apr 11, 10:50 AM
Unknown Object (File)
Mar 30 2024, 5:33 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/diffusion-observed-mercurial-repository-history-broken/825.

In D18769, I rewrote this from using the --branch flag (which is unsafe and does not function on branches named --config=x.y and such).

However, this rewrite accidentally changed the result order, which impacted Mercurial commit hisotry lists and graphs. Swap the order of the constraints so we get newest-to-oldest again, as expected.

Test Plan

Viewed a Mercurial repository's history graph, saw sensible chronology after the patch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable