Page MenuHomePhabricator

Fix Mercurial commit history ordering
ClosedPublic

Authored by epriestley on Dec 5 2017, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 5:40 PM
Unknown Object (File)
Fri, Jan 3, 3:58 AM
Unknown Object (File)
Dec 7 2024, 6:28 PM
Unknown Object (File)
Nov 27 2024, 2:53 AM
Unknown Object (File)
Nov 23 2024, 2:43 AM
Unknown Object (File)
Nov 18 2024, 9:27 PM
Unknown Object (File)
Nov 14 2024, 6:53 PM
Unknown Object (File)
Nov 11 2024, 3:19 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/diffusion-observed-mercurial-repository-history-broken/825.

In D18769, I rewrote this from using the --branch flag (which is unsafe and does not function on branches named --config=x.y and such).

However, this rewrite accidentally changed the result order, which impacted Mercurial commit hisotry lists and graphs. Swap the order of the constraints so we get newest-to-oldest again, as expected.

Test Plan

Viewed a Mercurial repository's history graph, saw sensible chronology after the patch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable