Page MenuHomePhabricator

Fix Mercurial commit history ordering
ClosedPublic

Authored by epriestley on Dec 5 2017, 1:38 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/diffusion-observed-mercurial-repository-history-broken/825.

In D18769, I rewrote this from using the --branch flag (which is unsafe and does not function on branches named --config=x.y and such).

However, this rewrite accidentally changed the result order, which impacted Mercurial commit hisotry lists and graphs. Swap the order of the constraints so we get newest-to-oldest again, as expected.

Test Plan

Viewed a Mercurial repository's history graph, saw sensible chronology after the patch.

Diff Detail

Repository
rP Phabricator
Branch
hg1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 18924
Build 25518: Run Core Tests
Build 25517: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Dec 5 2017, 5:02 PM
This revision was automatically updated to reflect the committed changes.