Page MenuHomePhabricator

Correct file PHID extraction on image update in Pholio
ClosedPublic

Authored by epriestley on May 30 2017, 6:52 PM.
Tags
None
Referenced Files
F13230825: D18042.id43397.diff
Mon, May 20, 11:20 PM
F13184358: D18042.id43397.diff
Fri, May 10, 6:06 PM
F13182178: D18042.id.diff
Thu, May 9, 8:38 PM
F13177507: D18042.diff
Wed, May 8, 7:45 PM
Unknown Object (File)
Wed, May 1, 8:59 PM
Unknown Object (File)
Apr 25 2024, 10:51 AM
Unknown Object (File)
Apr 25 2024, 1:25 AM
Unknown Object (File)
Apr 7 2024, 5:50 AM
Subscribers
None

Details

Summary

Ref T12776. This extraction of file PHIDs extracted "PholioImage" object PHIDs (PHID-PIMG-...), not "File" PHIDs (PHID-FILE-...). Instead, dig into the Pholio images and actually extract the file PHIDs. This method is now similar to the PholioImageFileTransaction method, which works already.

Test Plan
  • Create a mock.
  • Update one of the images.
  • In Files, view the "Attached" tab of the updated image.
  • Before patch: not attached to mock.
  • After patch: properly attached to mock.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17309
Build 23191: Run Core Tests
Build 23190: arc lint + arc unit