Page MenuHomePhabricator

Correct file PHID extraction on image update in Pholio
ClosedPublic

Authored by epriestley on May 30 2017, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 6:44 PM
Unknown Object (File)
Fri, Dec 27, 12:54 PM
Unknown Object (File)
Thu, Dec 26, 6:30 PM
Unknown Object (File)
Thu, Dec 19, 8:59 AM
Unknown Object (File)
Mon, Dec 9, 3:28 PM
Unknown Object (File)
Sat, Dec 7, 3:49 AM
Unknown Object (File)
Dec 5 2024, 3:40 PM
Unknown Object (File)
Dec 1 2024, 4:41 AM
Subscribers
None

Details

Summary

Ref T12776. This extraction of file PHIDs extracted "PholioImage" object PHIDs (PHID-PIMG-...), not "File" PHIDs (PHID-FILE-...). Instead, dig into the Pholio images and actually extract the file PHIDs. This method is now similar to the PholioImageFileTransaction method, which works already.

Test Plan
  • Create a mock.
  • Update one of the images.
  • In Files, view the "Attached" tab of the updated image.
  • Before patch: not attached to mock.
  • After patch: properly attached to mock.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17309
Build 23191: Run Core Tests
Build 23190: arc lint + arc unit