Page MenuHomePhabricator

Correct file PHID extraction on image update in Pholio
ClosedPublic

Authored by epriestley on May 30 2017, 6:52 PM.

Details

Summary

Ref T12776. This extraction of file PHIDs extracted "PholioImage" object PHIDs (PHID-PIMG-...), not "File" PHIDs (PHID-FILE-...). Instead, dig into the Pholio images and actually extract the file PHIDs. This method is now similar to the PholioImageFileTransaction method, which works already.

Test Plan
  • Create a mock.
  • Update one of the images.
  • In Files, view the "Attached" tab of the updated image.
  • Before patch: not attached to mock.
  • After patch: properly attached to mock.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 17309
Build 23191: Run Core Tests
Build 23190: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2017, 6:52 PM
chad accepted this revision.May 30 2017, 6:56 PM
This revision is now accepted and ready to land.May 30 2017, 6:56 PM
This revision was automatically updated to reflect the committed changes.