Page MenuHomePhabricator

Correct file PHID extraction on image update in Pholio
ClosedPublic

Authored by epriestley on May 30 2017, 6:52 PM.
Tags
None
Referenced Files
F20651028: D18042.diff
Sun, Jun 21, 4:11 AM
F20641576: D18042.id.diff
Sun, Jun 21, 12:29 AM
F20641575: D18042.id.diff
Sun, Jun 21, 12:29 AM
Unknown Object (File)
Wed, Jun 17, 11:03 PM
Unknown Object (File)
Apr 16 2026, 4:01 PM
Unknown Object (File)
Apr 2 2026, 6:20 PM
Unknown Object (File)
Mar 9 2026, 11:59 PM
Unknown Object (File)
Mar 9 2026, 5:42 PM
Subscribers
None

Details

Summary

Ref T12776. This extraction of file PHIDs extracted "PholioImage" object PHIDs (PHID-PIMG-...), not "File" PHIDs (PHID-FILE-...). Instead, dig into the Pholio images and actually extract the file PHIDs. This method is now similar to the PholioImageFileTransaction method, which works already.

Test Plan
  • Create a mock.
  • Update one of the images.
  • In Files, view the "Attached" tab of the updated image.
  • Before patch: not attached to mock.
  • After patch: properly attached to mock.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable