Differential D16936

Make logged-out users use global settings, not default settings
ClosedPublic
Actions

Authored by epriestley on Nov 23 2016, 10:06 PM.

Details

Reviewers

chad

Maniphest Tasks

T11917: Global default settings only apply to logged in users

Commits

rPa1025ca52e03: Make logged-out users use global settings, not default settings

Summary

Fixes T11917. Give logged-out / omnipotent users the global settings, not the default settings.

Test Plan

Changed applications and language, logged out, saw changes as a public user.

Diff Detail

Repository

rP Phabricator

Branch

viewercache

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14653
Build 19136: Run Core Tests
Build 19135: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40765.Nov 23 2016, 10:06 PM

epriestley retitled this revision from to Make logged-out users use global settings, not default settings.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11917: Global default settings only apply to logged in users.

chad accepted this revision.Nov 23 2016, 10:14 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2016, 10:14 PM

Closed by commit rPa1025ca52e03: Make logged-out users use global settings, not default settings (authored by epriestley, committed by epriestley). · Explain WhyNov 23 2016, 10:26 PM

This revision was automatically updated to reflect the committed changes.

mpickering awarded a token.Nov 23 2016, 10:26 PM

epriestley mentioned this in D16952: Fix local time test case for logged-out viewers using global settings.Nov 28 2016, 2:53 PM

epriestley mentioned this in rPab3b70739614: Fix local time test case for logged-out viewers using global settings.Nov 28 2016, 5:27 PM

epriestley mentioned this in T11952: Daemons don't notice changes to global default settings.Dec 5 2016, 10:35 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

storage/

PhabricatorUser.php

16 lines

Diff 40765

View Options

src/applications/people/storage/PhabricatorUser.php

Make logged-out users use global settings, not default settingsClosedPublicActions