Page MenuHomePhabricator
Differential D16952

Fix local time test case for logged-out viewers using global settings
ClosedPublic
Actions

Authored by epriestley on Nov 28 2016, 2:53 PM.
Tags
None
Referenced Files
F18703112: D16952.id40799.diff
Sun, Sep 28, 2:59 AM
F18702792: D16952.diff
Sun, Sep 28, 1:34 AM
F18589765: D16952.id.diff
Sep 12 2025, 4:13 AM
F18583681: D16952.diff
Sep 11 2025, 10:46 AM
F18508335: D16952.id.diff
Sep 5 2025, 2:45 AM
F18367351: D16952.id40799.diff
Aug 27 2025, 11:32 PM
F18212036: D16952.id40799.diff
Aug 19 2025, 2:31 AM
F18099843: D16952.id40806.diff
Aug 9 2025, 9:07 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPab3b70739614: Fix local time test case for logged-out viewers using global settings
Summary

In D16936, I changed logged-out viewers so they use global settings.

This can lead to a SELECT from an isolated unit test. Instead, give the test fixtures and use standard generateNewUser() stuff.

Test Plan

Ran arc unit --everything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40799.Nov 28 2016, 2:53 PM
epriestley retitled this revision from to Fix local time test case for logged-out viewers using global settings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Nov 28 2016, 4:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2016, 4:59 PM
Closed by commit rPab3b70739614: Fix local time test case for logged-out viewers using global settings (authored by epriestley, committed by epriestley). · Explain WhyNov 28 2016, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
__tests__/
10 lines

Diff 40806

View Options

src/view/__tests__/PhabricatorLocalTimeTestCase.php

Loading...
Phabricator · Built by Phacility