HomePhabricator
Diffusion Phabricator a1025ca52e03

Make logged-out users use global settings, not default settings
Auditeda1025ca52e03
Actions

Description

Make logged-out users use global settings, not default settings

Summary: Fixes T11917. Give logged-out / omnipotent users the global settings, not the default settings.

Test Plan: Changed applications and language, logged out, saw changes as a public user.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11917

Differential Revision: https://secure.phabricator.com/D16936

Details

Auditors
chad
• aHa
Provenance
epriestleyAuthored on Nov 23 2016, 10:05 PM
epriestleyPushed on Nov 23 2016, 10:26 PM
Reviewer
chad
Differential Revision
D16936: Make logged-out users use global settings, not default settings
Parents
rP8958d68ec648: When a Phortune subscription has a removed payment method, be more explicit…
Branches
Unknown
Tags
Unknown
Tasks
T11917: Global default settings only apply to logged in users
Build Status
Buildable 14655
Build 19138: Run Core Tests

Event Timeline

epriestley committed rPa1025ca52e03: Make logged-out users use global settings, not default settings (authored by epriestley).Nov 23 2016, 10:26 PM
epriestley added a task: T11917: Global default settings only apply to logged in users.
Harbormaster completed building B14655: rPa1025ca52e03: Make logged-out users use global settings, not default settings.Nov 23 2016, 10:27 PM
• aHa raised a concern with this commit.EditedDec 4 2016, 4:10 PM
• aHa added a subscriber: • aHa.

This works only for Installs with policy.allow-public=true. In my Install with policy.allow-public=false it don't change the language of the login mask, which is set by global setting on my install. (Set it to true and it works, but it has to remain at false)

chad added a subscriber: chad.Dec 4 2016, 4:15 PM

File a bug report please.

chad accepted this commit.Dec 4 2016, 4:16 PM

and clear the concern, please.

• aHa mentioned this in T11946: Global default settings only apply to logged-out users on public installs.Dec 4 2016, 4:25 PM
chad added a comment.EditedDec 4 2016, 4:57 PM

@aHa can you clear this please. We don't want users raising concerns on this instance since it bypasses our bug reporting guidelines. We also only expect a concern to be raised in Audit if something is actually broken by the commit.

• aHa added a comment.EditedDec 4 2016, 8:20 PM

sorry, if it was wrong to post that here. I posted it here because the commit solves it only partly. I made a report: T11946

• aHa accepted this commit.Dec 4 2016, 8:31 PM

Changes (1)

PathSize
src/
applications/
people/
storage/

rPa1025ca52e03

View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility