Differential D14487

Remove arguments from unit test engines
ClosedPublic
Actions

Authored by joshuaspence on Nov 15 2015, 8:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 1:20 AM

	Unknown Object (File)
	Sun, Apr 21, 9:31 PM

	Unknown Object (File)
	Tue, Apr 16, 7:47 AM

	Unknown Object (File)
	Sat, Mar 30, 12:51 AM

	Unknown Object (File)
	Mar 22 2024, 7:12 AM

	Unknown Object (File)
	Mar 19 2024, 8:10 PM

	Unknown Object (File)
	Mar 8 2024, 12:48 PM

	Unknown Object (File)
	Mar 6 2024, 5:15 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9131: `arc unit` doesn't output progressive results

Commits

rARC66ab1c955d27: Remove arguments from unit test engines

Summary

Ref T9131. This doesn't seem to be used... it seems like it is a relic of postponed test results.

Test Plan

N/A

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8855
Build 10350: Run Core Tests
Build 10349: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35045.Nov 15 2015, 8:26 AM

joshuaspence retitled this revision from to Remove arguments from unit test engines.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T9131: `arc unit` doesn't output progressive results.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 15 2015, 8:26 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 15 2015, 4:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2015, 4:18 PM

Closed by commit rARC66ab1c955d27: Remove arguments from unit test engines (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 15 2015, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Locally, I had this applied on top of D14486 and D14037 (although all three diffs have no real relationship between them). When I used the "land revision" functionality, all three diffs were landed. I don't think that this is expected, but it's at least partially my fault for not maintaining a clean working copy.

Revision Contents
Changeset List

Path

Size

src/

unit/

engine/

ArcanistUnitTestEngine.php

10 lines

workflow/

ArcanistUnitWorkflow.php

1 line

Diff 35045

src/unit/engine/ArcanistUnitTestEngine.php

Loading...

src/workflow/ArcanistUnitWorkflow.php

Loading...