Page MenuHomePhabricator
Differential D14487

Remove arguments from unit test engines
ClosedPublic
Actions

Authored by joshuaspence on Nov 15 2015, 8:26 AM.
Tags
None
Referenced Files
F19069041: D14487.diff
Sun, Nov 30, 12:57 PM
F18906005: D14487.id35050.diff
Sat, Nov 8, 4:30 PM
F18905720: D14487.diff
Sat, Nov 8, 3:25 PM
F18895861: D14487.id.diff
Fri, Nov 7, 3:29 PM
F18853404: D14487.id35050.diff
Fri, Oct 31, 4:15 PM
F18770208: D14487.id.diff
Oct 8 2025, 11:22 AM
F18757699: D14487.id35050.diff
Oct 5 2025, 7:04 PM
F18757156: D14487.diff
Oct 5 2025, 3:47 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9131: `arc unit` doesn't output progressive results
Commits
rARC66ab1c955d27: Remove arguments from unit test engines
Summary

Ref T9131. This doesn't seem to be used... it seems like it is a relic of postponed test results.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8855
Build 10350: Run Core Tests
Build 10349: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35045.Nov 15 2015, 8:26 AM
joshuaspence retitled this revision from to Remove arguments from unit test engines.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T9131: `arc unit` doesn't output progressive results.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 15 2015, 8:26 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 15 2015, 4:18 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2015, 4:18 PM
Closed by commit rARC66ab1c955d27: Remove arguments from unit test engines (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 15 2015, 8:05 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D14037: Allow unit test engines to render their own results.Nov 15 2015, 8:10 PM
joshuaspence mentioned this in D14486: Remove "async" mode from test engines.

Locally, I had this applied on top of D14486 and D14037 (although all three diffs have no real relationship between them). When I used the "land revision" functionality, all three diffs were landed. I don't think that this is expected, but it's at least partially my fault for not maintaining a clean working copy.

Revision Contents
Changeset List

PathSize
src/
unit/
engine/
10 lines
workflow/
1 line

Diff 35045

View Options

src/unit/engine/ArcanistUnitTestEngine.php

Loading...
View Options

src/workflow/ArcanistUnitWorkflow.php

Loading...
Phabricator · Built by Phacility