Differential D14487

Remove arguments from unit test engines
ClosedPublic
Actions

Authored by joshuaspence on Nov 15 2015, 8:26 AM.

Tags

None

Referenced Files

	F14797141: D14487.id.diff
	Sat, Jan 25, 4:43 AM

	Unknown Object (File)
	Fri, Jan 24, 9:58 AM

	Unknown Object (File)
	Fri, Jan 24, 9:57 AM

	Unknown Object (File)
	Fri, Jan 24, 9:57 AM

	Unknown Object (File)
	Thu, Jan 23, 6:13 AM

	Unknown Object (File)
	Tue, Jan 21, 11:29 AM

	Unknown Object (File)
	Sun, Jan 19, 11:54 AM

	Unknown Object (File)
	Thu, Jan 16, 8:18 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9131: `arc unit` doesn't output progressive results

Commits

rARC66ab1c955d27: Remove arguments from unit test engines

Summary

Ref T9131. This doesn't seem to be used... it seems like it is a relic of postponed test results.

Test Plan

N/A

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35045.Nov 15 2015, 8:26 AM

joshuaspence retitled this revision from to Remove arguments from unit test engines.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T9131: `arc unit` doesn't output progressive results.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 15 2015, 8:26 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 15 2015, 4:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2015, 4:18 PM

Closed by commit rARC66ab1c955d27: Remove arguments from unit test engines (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 15 2015, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Locally, I had this applied on top of D14486 and D14037 (although all three diffs have no real relationship between them). When I used the "land revision" functionality, all three diffs were landed. I don't think that this is expected, but it's at least partially my fault for not maintaining a clean working copy.

Revision Contents
Changeset List

Path

Size

src/

unit/

engine/

ArcanistConfigurationDrivenUnitTestEngine.php

29 lines

ArcanistUnitTestEngine.php

22 lines

PhutilUnitTestEngine.php

4 lines

workflow/

ArcanistUnitWorkflow.php

8 lines

Diff 35050

src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php

Loading...

src/unit/engine/ArcanistUnitTestEngine.php

Loading...

src/unit/engine/PhutilUnitTestEngine.php

Loading...

src/workflow/ArcanistUnitWorkflow.php

Loading...