Page MenuHomePhabricator
Differential D14369

Allow any {icon} to spin
ClosedPublic
Actions

Authored by epriestley on Oct 30 2015, 4:00 PM.
Tags
None
Referenced Files
F14837694: D14369.id34694.diff
Fri, Jan 31, 10:55 AM
Unknown Object (File)
Tue, Jan 28, 12:23 PM
Unknown Object (File)
Tue, Jan 28, 3:55 AM
Unknown Object (File)
Tue, Jan 28, 3:55 AM
Unknown Object (File)
Tue, Jan 28, 3:55 AM
Unknown Object (File)
Tue, Jan 28, 3:55 AM
Unknown Object (File)
Fri, Jan 24, 9:34 AM
Unknown Object (File)
Fri, Jan 24, 9:34 AM
View All Files
Subscribers
joshuaspence
Mnkras
talshiri
tycho.tatitscheff
Tokens
"Manufacturing Defect?" token, awarded by avivey.

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP096117aacded: Allow any {icon} to spin
Summary

We are greedily hoarding this for ourselves, when we could enrich the world.

Test Plan

Used {icon cog spin}.

Diff Detail

Repository
rP Phabricator
Branch
spinall
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8499
Build 9797: Run Core Tests
Build 9796: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34692.Oct 30 2015, 4:00 PM
epriestley retitled this revision from to Allow any {icon} to spin.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Oct 30 2015, 4:00 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2015, 4:00 PM
Closed by commit rP096117aacded: Allow any {icon} to spin (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2015, 4:02 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a subscriber: joshuaspence.Oct 30 2015, 9:21 PM

talshiri added a subscriber: talshiri.Oct 30 2015, 10:09 PM

My favorite commit of 2015.

tycho.tatitscheff added a subscriber: tycho.tatitscheff.Oct 30 2015, 10:28 PM

I think we need a theyseemerolling macro for the occasion

Mnkras added a subscriber: Mnkras.Oct 30 2015, 11:38 PM

I really hoped that this allowed the ability to spin memes, but I was disappointed

avivey awarded a token.Oct 30 2015, 11:45 PM

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
markup/
11 lines
docs/
user/
userguide/
6 lines

Diff 34692

View Options

src/applications/macro/markup/PhabricatorIconRemarkupRule.php

Loading...
View Options

src/docs/user/userguide/remarkup.diviner

Loading...
Phabricator · Built by Phacility