Page MenuHomePhabricator
Differential D14070

Add a `phutil_count` function
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2015, 4:52 AM.
Tags
None
Referenced Files
F15507868: D14070.id34720.diff
Tue, Apr 15, 11:37 PM
F15500585: D14070.id34713.diff
Sun, Apr 13, 6:32 PM
F15495550: D14070.id34714.diff
Sun, Apr 13, 4:54 AM
F15491739: D14070.id34713.diff
Sat, Apr 12, 6:57 AM
F15490523: D14070.id34716.diff
Fri, Apr 11, 6:09 PM
F15487500: D14070.id34713.diff
Thu, Apr 10, 2:38 PM
F15486465: D14070.id34010.diff
Thu, Apr 10, 7:17 AM
F15486017: D14070.id.diff
Thu, Apr 10, 4:23 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU9e4d97fa55a8: Add a `phutil_count` function
Summary

This function is a shorthand for new PhutilNumber(count($x)).

Test Plan

See next diff.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7927
Build 8883: [Placeholder Plan] Wait for 30 Seconds
Build 8882: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 34010.Sep 6 2015, 4:52 AM
joshuaspence retitled this revision from to Add a `phutil_number` function.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2015, 4:52 AM
Herald added a subscriber: Korvin. · View Herald Transcript
avivey retitled this revision from Add a `phutil_number` function to Add a `phutil_count` function.Sep 6 2015, 5:18 AM
avivey edited edge metadata.
joshuaspence added a child revision: D14071: Various translation improvements.Sep 6 2015, 6:12 AM
joshuaspence added a child revision: D14072: Various translation improvements.
joshuaspence added a child revision: D14073: Various translation improvements.Sep 6 2015, 6:15 AM
epriestley accepted this revision.Sep 6 2015, 3:05 PM
epriestley edited edge metadata.

Maybe pht_count()?

Maybe let it take take an integer too?

src/internationalization/pht.php
26

Function spelled wrong (phnutil should be phutil).

This revision is now accepted and ready to land.Sep 6 2015, 3:05 PM
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM
joshuaspence updated this revision to Diff 34713.Nov 2 2015, 8:56 AM
joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.

Fix typo

joshuaspence updated this revision to Diff 34714.Nov 2 2015, 8:57 AM

Add typehint

joshuaspence updated this revision to Diff 34716.Nov 2 2015, 9:14 AM

Remove type hint

Closed by commit rPHU9e4d97fa55a8: Add a `phutil_count` function (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 2 2015, 10:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
internationalization/
10 lines

Diff 34010

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/internationalization/pht.php

Loading...
Phabricator · Built by Phacility