Page MenuHomePhabricator

Add a `phutil_count` function
ClosedPublic

Authored by joshuaspence on Sep 6 2015, 4:52 AM.

Details

Summary

This function is a shorthand for new PhutilNumber(count($x)).

Test Plan

See next diff.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8524
Build 9833: Run Core Tests
Build 9832: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Add a `phutil_number` function.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
avivey retitled this revision from Add a `phutil_number` function to Add a `phutil_count` function.Sep 6 2015, 5:18 AM
avivey edited edge metadata.
epriestley edited edge metadata.

Maybe pht_count()?

Maybe let it take take an integer too?

src/internationalization/pht.php
26

Function spelled wrong (phnutil should be phutil).

This revision is now accepted and ready to land.Sep 6 2015, 3:05 PM
joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.

Fix typo

This revision was automatically updated to reflect the committed changes.