Page MenuHomePhabricator

Various translation improvements
ClosedPublic

Authored by joshuaspence on Sep 6 2015, 6:12 AM.

Details

Summary

Depends on D14070.

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Various translation improvements.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/moduleutils/PhutilLibraryMapBuilder.php
471

Does phutil_count() actually exist? I can't find it defined anywhere. Maybe I'm reviewing these out of order...

Probably should be file(s).

src/utils/viewutils.php
7–9 ↗(On Diff #34011)

Maybe just leave these for now -- I think there's some intentional code which tries to localize them. But we're moving away from this in general, so probably fine either way.

This revision is now accepted and ready to land.Sep 6 2015, 3:04 PM
joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.

Leave strings in phutil_date_format untouched

joshuaspence marked an inline comment as done.

Minor fixes

This revision was automatically updated to reflect the committed changes.