Page MenuHomePhabricator

[Redesign] Add back limited header-color options
ClosedPublic

Authored by chad on May 27 2015, 8:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 11:39 PM
Unknown Object (File)
Wed, Apr 17, 5:24 PM
Unknown Object (File)
Sat, Apr 13, 11:04 AM
Unknown Object (File)
Fri, Apr 12, 10:05 PM
Unknown Object (File)
Mar 5 2024, 5:45 AM
Unknown Object (File)
Mar 4 2024, 7:16 AM
Unknown Object (File)
Feb 14 2024, 3:25 PM
Unknown Object (File)
Feb 10 2024, 4:05 PM
Subscribers

Details

Summary

Ref T8099. Adds back basic header color options, which change the logo color instead. Also RAINBOW.

Test Plan

tested each of the new colors.

pasted_file (203×421 px, 39 KB)

Diff Detail

Repository
rP Phabricator
Branch
header-colors
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6318
Build 6340: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to [Redesign] Add back limited header-color options.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 27 2015, 9:51 PM

I'm completely fine with throwing these out, but I also love them.

This revision was automatically updated to reflect the committed changes.

One question, if you had something previously selected that isn’t in the new design, it breaks the logo. Is there a way to default this better?

Filed T8330 to do that automatically. We should be able to, we just don't currently.