[Redesign] Add back limited header-color options
ClosedPublic
Actions

Authored by chad on May 27 2015, 8:42 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rPe81ec738f3ea: [Redesign] Add back limited header-color options

Summary

Ref T8099. Adds back basic header color options, which change the logo color instead. Also RAINBOW.

Test Plan

tested each of the new colors.

Diff Detail

Repository

rP Phabricator

Branch

header-colors

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6318
Build 6340: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 31459.May 27 2015, 8:42 PM

chad retitled this revision from to [Redesign] Add back limited header-color options.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 27 2015, 8:42 PM

chad edited the test plan for this revision. (Show Details)May 27 2015, 8:42 PM

joshuaspence mentioned this in T8327: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage() must be an instance of PhabricatorFile.May 27 2015, 8:53 PM

• sshannin mentioned this in T6997: Show prefix or project for commits in feeds.May 27 2015, 9:05 PM

epriestley accepted this revision.May 27 2015, 9:51 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 27 2015, 9:51 PM

I'm completely fine with throwing these out, but I also love them.

Closed by commit rPe81ec738f3ea: [Redesign] Add back limited header-color options (authored by chad, committed by chad). · Explain WhyMay 27 2015, 9:56 PM

This revision was automatically updated to reflect the committed changes.

One question, if you had something previously selected that isn’t in the new design, it breaks the logo. Is there a way to default this better?

Filed T8330 to do that automatically. We should be able to, we just don't currently.

chad mentioned this in T4214: Allow installs to change or supplement the "Phabricator" icon.May 28 2015, 2:24 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

packages.php

1 line

sprite/

main_header/

manifest/

68 lines

menu_1x/

	dark-eye.png
	eye.png

	dark-logo.png
	logo.png

menu_2x/

	dark-eye.png
	eye.png

	dark-logo.png
	logo.png

scripts/

celerity/

generate_sprites.php

1 line

src/

applications/

celerity/

CeleritySpriteGenerator.php

52 lines

config/

option/

PhabricatorUIConfigOptions.php

14 lines

view/

page/

menu/

PhabricatorMainMenuView.php

6 lines

webroot/

rsrc/

css/

sprite-main-header.css

sprite-menu.css

46 lines

image/

sprite-main-header.png

sprite-menu-X2.png

sprite-menu.png

Diff 31459

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

resources/sprite/main_header/applebloom.png

View Options

resources/sprite/main_header/blindigo.png

View Options

resources/sprite/main_header/blue.png

View Options

resources/sprite/main_header/dark.png

View Options

resources/sprite/main_header/fluttershy.png

View Options

resources/sprite/main_header/green.png

View Options

resources/sprite/main_header/indigo.png

View Options

resources/sprite/main_header/nightmaremoon.png

View Options

resources/sprite/main_header/red.png

View Options

resources/sprite/main_header/scootaloo.png

View Options

resources/sprite/main_header/yellow.png

View Options

resources/sprite/manifest/main-header.json

View Options

resources/sprite/manifest/menu.json

View Options

resources/sprite/menu_1x/blindigo-eye.png

View Options

resources/sprite/menu_1x/blindigo-logo.png

View Options

resources/sprite/menu_1x/blue-eye.png

View Options

resources/sprite/menu_1x/blue-logo.png

View Options

resources/sprite/menu_1x/dark-eye.png

View Options

resources/sprite/menu_1x/dark-logo.png

View Options

resources/sprite/menu_1x/eye.png

View Options

resources/sprite/menu_1x/indigo-eye.png

View Options

resources/sprite/menu_1x/indigo-logo.png

View Options

resources/sprite/menu_1x/logo.png

View Options

resources/sprite/menu_1x/rainbow-eye.png

View Options

resources/sprite/menu_1x/rainbow-logo.png

View Options

resources/sprite/menu_1x/red-eye.png

View Options

resources/sprite/menu_1x/red-logo.png

View Options

resources/sprite/menu_2x/blindigo-eye.png

View Options

resources/sprite/menu_2x/blindigo-logo.png

View Options

resources/sprite/menu_2x/blue-eye.png

View Options

resources/sprite/menu_2x/blue-logo.png

View Options

resources/sprite/menu_2x/dark-eye.png

View Options

resources/sprite/menu_2x/dark-logo.png

View Options

resources/sprite/menu_2x/eye.png

View Options

resources/sprite/menu_2x/indigo-eye.png

View Options

resources/sprite/menu_2x/indigo-logo.png

View Options

resources/sprite/menu_2x/logo.png

View Options

resources/sprite/menu_2x/rainbow-eye.png

View Options

resources/sprite/menu_2x/rainbow-logo.png

View Options

resources/sprite/menu_2x/red-eye.png

View Options

resources/sprite/menu_2x/red-logo.png

View Options

scripts/celerity/generate_sprites.php

View Options

src/applications/celerity/CeleritySpriteGenerator.php

View Options

src/applications/config/option/PhabricatorUIConfigOptions.php

View Options

src/view/page/menu/PhabricatorMainMenuView.php

View Options

webroot/rsrc/css/sprite-main-header.css

View Options

webroot/rsrc/css/sprite-menu.css

View Options

webroot/rsrc/image/sprite-main-header.png

View Options

webroot/rsrc/image/sprite-menu-X2.png

View Options

webroot/rsrc/image/sprite-menu.png

[Redesign] Add back limited header-color optionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31459

resources/celerity/map.php

resources/celerity/packages.php

resources/sprite/main_header/applebloom.png

resources/sprite/main_header/blindigo.png

resources/sprite/main_header/blue.png

resources/sprite/main_header/dark.png

resources/sprite/main_header/fluttershy.png

resources/sprite/main_header/green.png

resources/sprite/main_header/indigo.png

resources/sprite/main_header/nightmaremoon.png

resources/sprite/main_header/red.png

resources/sprite/main_header/scootaloo.png

resources/sprite/main_header/yellow.png

resources/sprite/manifest/main-header.json

resources/sprite/manifest/menu.json

resources/sprite/menu_1x/blindigo-eye.png

resources/sprite/menu_1x/blindigo-logo.png

resources/sprite/menu_1x/blue-eye.png

resources/sprite/menu_1x/blue-logo.png

resources/sprite/menu_1x/dark-eye.png

resources/sprite/menu_1x/dark-logo.png

resources/sprite/menu_1x/eye.png

resources/sprite/menu_1x/indigo-eye.png

resources/sprite/menu_1x/indigo-logo.png

resources/sprite/menu_1x/logo.png

resources/sprite/menu_1x/rainbow-eye.png

resources/sprite/menu_1x/rainbow-logo.png

resources/sprite/menu_1x/red-eye.png

resources/sprite/menu_1x/red-logo.png

resources/sprite/menu_2x/blindigo-eye.png

resources/sprite/menu_2x/blindigo-logo.png

resources/sprite/menu_2x/blue-eye.png

resources/sprite/menu_2x/blue-logo.png

resources/sprite/menu_2x/dark-eye.png

resources/sprite/menu_2x/dark-logo.png

resources/sprite/menu_2x/eye.png

resources/sprite/menu_2x/indigo-eye.png

resources/sprite/menu_2x/indigo-logo.png

resources/sprite/menu_2x/logo.png

resources/sprite/menu_2x/rainbow-eye.png

resources/sprite/menu_2x/rainbow-logo.png

resources/sprite/menu_2x/red-eye.png

resources/sprite/menu_2x/red-logo.png

scripts/celerity/generate_sprites.php

src/applications/celerity/CeleritySpriteGenerator.php

src/applications/config/option/PhabricatorUIConfigOptions.php

src/view/page/menu/PhabricatorMainMenuView.php

webroot/rsrc/css/sprite-main-header.css

webroot/rsrc/css/sprite-menu.css

webroot/rsrc/image/sprite-main-header.png

webroot/rsrc/image/sprite-menu-X2.png

webroot/rsrc/image/sprite-menu.png

[Redesign] Add back limited header-color options
ClosedPublic
Actions

Revision Contents
Changeset List