Page MenuHomePhabricator
Differential D13040

[Redesign] Add back limited header-color options
ClosedPublic
Actions

Authored by chad on May 27 2015, 8:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 6:11 AM
Unknown Object (File)
Fri, Dec 13, 2:47 PM
Unknown Object (File)
Thu, Dec 12, 6:56 AM
Unknown Object (File)
Tue, Dec 10, 8:11 AM
Unknown Object (File)
Sun, Dec 8, 2:33 PM
Unknown Object (File)
Thu, Dec 5, 11:42 PM
Unknown Object (File)
Thu, Dec 5, 4:40 AM
Unknown Object (File)
Wed, Dec 4, 12:10 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rPe81ec738f3ea: [Redesign] Add back limited header-color options
Summary

Ref T8099. Adds back basic header color options, which change the logo color instead. Also RAINBOW.

Test Plan

tested each of the new colors.

pasted_file (203×421 px, 39 KB)

Diff Detail

Repository
rP Phabricator
Branch
header-colors
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6318
Build 6340: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 31459.May 27 2015, 8:42 PM
chad retitled this revision from to [Redesign] Add back limited header-color options.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 27 2015, 8:42 PM
chad edited the test plan for this revision. (Show Details)May 27 2015, 8:42 PM
joshuaspence mentioned this in T8327: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage() must be an instance of PhabricatorFile.May 27 2015, 8:53 PM
• sshannin mentioned this in T6997: Show prefix or project for commits in feeds.May 27 2015, 9:05 PM
epriestley accepted this revision.May 27 2015, 9:51 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 27 2015, 9:51 PM
epriestley added a comment.May 27 2015, 9:52 PM

I'm completely fine with throwing these out, but I also love them.

Closed by commit rPe81ec738f3ea: [Redesign] Add back limited header-color options (authored by chad, committed by chad). · Explain WhyMay 27 2015, 9:56 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.May 27 2015, 10:01 PM

One question, if you had something previously selected that isn’t in the new design, it breaks the logo. Is there a way to default this better?

epriestley mentioned this in T8330: Detect/repair invalid "enum" config.May 27 2015, 10:11 PM

Filed T8330 to do that automatically. We should be able to, we just don't currently.

chad mentioned this in T4214: Allow installs to change or supplement the "Phabricator" icon.May 28 2015, 2:24 PM

Revision Contents
Changeset List

Diff 31459

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

resources/sprite/main_header/applebloom.png

Loading...
View Options

resources/sprite/main_header/blindigo.png

Loading...
View Options

resources/sprite/main_header/blue.png

Loading...
View Options

resources/sprite/main_header/dark.png

Loading...
View Options

resources/sprite/main_header/fluttershy.png

Loading...
View Options

resources/sprite/main_header/green.png

Loading...
View Options

resources/sprite/main_header/indigo.png

Loading...
View Options

resources/sprite/main_header/nightmaremoon.png

Loading...
View Options

resources/sprite/main_header/red.png

Loading...
View Options

resources/sprite/main_header/scootaloo.png

Loading...
View Options

resources/sprite/main_header/yellow.png

Loading...
View Options

resources/sprite/manifest/main-header.json

Loading...
View Options

resources/sprite/manifest/menu.json

Loading...
View Options

resources/sprite/menu_1x/blindigo-eye.png

Loading...
View Options

resources/sprite/menu_1x/blindigo-logo.png

Loading...
View Options

resources/sprite/menu_1x/blue-eye.png

Loading...
View Options

resources/sprite/menu_1x/blue-logo.png

Loading...
View Options

resources/sprite/menu_1x/dark-eye.png

Loading...
View Options

resources/sprite/menu_1x/dark-logo.png

Loading...
View Options

resources/sprite/menu_1x/eye.png

Loading...
View Options

resources/sprite/menu_1x/indigo-eye.png

Loading...
View Options

resources/sprite/menu_1x/indigo-logo.png

Loading...
View Options

resources/sprite/menu_1x/logo.png

Loading...
View Options

resources/sprite/menu_1x/rainbow-eye.png

Loading...
View Options

resources/sprite/menu_1x/rainbow-logo.png

Loading...
View Options

resources/sprite/menu_1x/red-eye.png

Loading...
View Options

resources/sprite/menu_1x/red-logo.png

Loading...
View Options

resources/sprite/menu_2x/blindigo-eye.png

Loading...
View Options

resources/sprite/menu_2x/blindigo-logo.png

Loading...
View Options

resources/sprite/menu_2x/blue-eye.png

Loading...
View Options

resources/sprite/menu_2x/blue-logo.png

Loading...
View Options

resources/sprite/menu_2x/dark-eye.png

Loading...
View Options

resources/sprite/menu_2x/dark-logo.png

Loading...
View Options

resources/sprite/menu_2x/eye.png

Loading...
View Options

resources/sprite/menu_2x/indigo-eye.png

Loading...
View Options

resources/sprite/menu_2x/indigo-logo.png

Loading...
View Options

resources/sprite/menu_2x/logo.png

Loading...
View Options

resources/sprite/menu_2x/rainbow-eye.png

Loading...
View Options

resources/sprite/menu_2x/rainbow-logo.png

Loading...
View Options

resources/sprite/menu_2x/red-eye.png

Loading...
View Options

resources/sprite/menu_2x/red-logo.png

Loading...
View Options

scripts/celerity/generate_sprites.php

Loading...
View Options

src/applications/celerity/CeleritySpriteGenerator.php

Loading...
View Options

src/applications/config/option/PhabricatorUIConfigOptions.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuView.php

Loading...
View Options

webroot/rsrc/css/sprite-main-header.css

Loading...
View Options

webroot/rsrc/css/sprite-menu.css

Loading...
View Options

webroot/rsrc/image/sprite-main-header.png

Loading...
View Options

webroot/rsrc/image/sprite-menu-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-menu.png

Loading...
Phabricator · Built by Phacility