Paths

Table of Contentst

Differential D12803

Add PhutilInvalidStateException class
ClosedPublic
Actions

Authored by joshuaspence on May 12 2015, 11:19 AM.

Tags

None

Referenced Files

	F13213161: D12803.diff
	Fri, May 17, 7:27 AM

	F13201601: D12803.id30847.diff
	Tue, May 14, 1:29 PM

	Unknown Object (File)
	Tue, May 7, 5:21 AM

	Unknown Object (File)
	Fri, May 3, 2:44 AM

	Unknown Object (File)
	Wed, May 1, 7:49 PM

	Unknown Object (File)
	Mon, Apr 29, 2:17 PM

	Unknown Object (File)
	Wed, Apr 24, 10:24 PM

	Unknown Object (File)
	Mon, Apr 22, 3:49 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHUf06c0b71f369: Add PhutilInvalidStateException class

Summary

There's a bunch of Call %s before calling %s! exceptions that can be simplified with a custom script.

Test Plan

Wrote unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5913
Build 5933: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	8,586 ms	PhabricatorCelerityTestCase::testCelerityMaps
	789 ms	CelerityResourceTransformerTestCase::testTransformation
	10,558 ms	DifferentialParseRenderTestCase::testParseRender
	1,790 ms	DiffusionGitFileContentQueryTestCase::testAuthorName
	1,557 ms	PhabricatorAphrontViewTestCase::testHasChildren
		View Full Test Results (1 Failed · 16 Passed)

Event Timeline

joshuaspence updated this revision to Diff 30779.May 12 2015, 11:19 AM

joshuaspence retitled this revision from to Add PhabricatorInvalidStateException.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2015, 11:19 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

What do you think about putting this in libphutil? We probably have very few arcanist/libphutil callsites, but this doens't feel Phabricator-specific to me.

Yeah, I was considering that. Will do.

Move to rPHU

Use PhutilInvalidStateException

joshuaspence retitled this revision from Add PhabricatorInvalidStateException to Add PhutilInvalidStateException class.May 13 2015, 9:36 PM

joshuaspence added a child revision: D12829: Use PhutilInvalidStateException.May 13 2015, 9:37 PM

epriestley accepted this revision.May 13 2015, 9:51 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 13 2015, 9:51 PM

Closed by commit rPHUf06c0b71f369: Add PhutilInvalidStateException class (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 9:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

auth/

provider/

PhabricatorAuthProvider.php

6 lines

celerity/

CelerityResourceGraph.php

5 lines

config/

option/

PhabricatorConfigOption.php

5 lines

schema/

PhabricatorConfigSchemaQuery.php

5 lines

daemon/

view/

PhabricatorDaemonLogEventsView.php

5 lines

PhabricatorDaemonLogListView.php

5 lines

differential/

view/

DifferentialLocalCommitsView.php

6 lines

DifferentialRevisionListView.php

6 lines

diffusion/

query/

DiffusionLintCountQuery.php

12 lines

lowlevel/

DiffusionLowLevelQuery.php

6 lines

diviner/

atom/

DivinerAtom.php

12 lines

doorkeeper/

view/

DoorkeeperTagView.php

6 lines

files/

controller/

PhabricatorFileDataController.php

6 lines

fund/

phortune/

FundBackerCart.php

5 lines

multimeter/

data/

MultimeterControl.php

5 lines

paste/

view/

PasteEmbedView.php

6 lines

phid/

query/

PhabricatorObjectQuery.php

6 lines

pholio/

view/

PholioMockEmbedView.php

6 lines

phortune/

cart/

PhortuneSubscriptionCart.php

5 lines

search/

controller/

PhabricatorApplicationSearchController.php

10 lines

engine/

PhabricatorApplicationSearchEngine.php

5 lines

slowvote/

view/

SlowvoteEmbedView.php

6 lines

subscriptions/

editor/

PhabricatorSubscriptionsEditor.php

6 lines

transactions/

editor/

PhabricatorApplicationTransactionCommentEditor.php

6 lines

PhabricatorApplicationTransactionEditor.php

6 lines

view/

PhabricatorApplicationTransactionCommentView.php

6 lines

infrastructure/

diff/

view/

PHUIDiffInlineCommentEditView.php

12 lines

exception/

PhabricatorInvalidStateException.php

30 lines

__tests__/

PhabricatorInvalidStateExceptionTestCase.php

18 lines

view/

control/

AphrontCursorPagerView.php

24 lines

AphrontPagerView.php

6 lines

phui/

PHUIRemarkupPreviewPanel.php

10 lines

calendar/

PHUICalendarMonthView.php

6 lines

widget/

hovercard/

PhabricatorHovercardView.php

6 lines

Diff 30779

src/__phutil_library_map__.php

Loading...

src/applications/auth/provider/PhabricatorAuthProvider.php

Loading...

src/applications/celerity/CelerityResourceGraph.php

Loading...

src/applications/config/option/PhabricatorConfigOption.php

Loading...

src/applications/config/schema/PhabricatorConfigSchemaQuery.php

Loading...

src/applications/daemon/view/PhabricatorDaemonLogEventsView.php

Loading...

src/applications/daemon/view/PhabricatorDaemonLogListView.php

Loading...

src/applications/differential/view/DifferentialLocalCommitsView.php

Loading...

src/applications/differential/view/DifferentialRevisionListView.php

Loading...

src/applications/diffusion/query/DiffusionLintCountQuery.php

Loading...

src/applications/diffusion/query/lowlevel/DiffusionLowLevelQuery.php

Loading...

src/applications/diviner/atom/DivinerAtom.php

Loading...

src/applications/doorkeeper/view/DoorkeeperTagView.php

Loading...

src/applications/files/controller/PhabricatorFileDataController.php

Loading...

src/applications/fund/phortune/FundBackerCart.php

Loading...

src/applications/multimeter/data/MultimeterControl.php

Loading...

src/applications/paste/view/PasteEmbedView.php

Loading...

src/applications/phid/query/PhabricatorObjectQuery.php

Loading...

src/applications/pholio/view/PholioMockEmbedView.php

Loading...

src/applications/phortune/cart/PhortuneSubscriptionCart.php

Loading...

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...

src/applications/slowvote/view/SlowvoteEmbedView.php

Loading...

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditor.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

Loading...

src/infrastructure/exception/PhabricatorInvalidStateException.php

Loading...

src/infrastructure/exception/tests/PhabricatorInvalidStateExceptionTestCase.php

Loading...

src/view/control/AphrontCursorPagerView.php

Loading...

src/view/control/AphrontPagerView.php

Loading...

src/view/phui/PHUIRemarkupPreviewPanel.php

Loading...

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...

src/view/widget/hovercard/PhabricatorHovercardView.php

Loading...